Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the intents extension version number #1167

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

The version number on the new intents extension wasn't set correctly. This PR updates that so that the version number is the same as the main target.

Test

  1. Go to the project navigator in Xcode, select the IntentsExtension -> Build Settings and filter for Version
  2. Confirm that the marketing version is 2.20 and the project version is 11258

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the tooling Related to anything that supports the building & maintaining of the project. label May 31, 2024
@charliescheer charliescheer self-assigned this May 31, 2024
@charliescheer charliescheer added this to the 2.21 milestone May 31, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@charliescheer charliescheer merged commit 33fa550 into trunk Jun 4, 2024
8 checks passed
@charliescheer charliescheer deleted the charlie/fix-intents-version-number branch June 4, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants