Setup saving simperium token to keychain on simperium did login #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
approved these changes
Jun 6, 2024
| @@ -10,3 +10,6 @@ gem 'fastlane-plugin-sentry', '~> 1.14' | |||
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 9.2' | |||
| gem 'rake', '~> 12.3' | |||
| gem 'xcpretty-travis-formatter', '~> 1.0' | |||
|
|
|||
| plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile') | |||
| eval_gemfile(plugins_path) if File.exist?(plugins_path) | |||
There was a problem hiding this comment.
Not sure what's this for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
So the next shortcut/intent that we need to add is to be able to update a note from a shortcut. This is best done using the simperium API so that versioning is handled on the server. To do that we need to be able to access the api token that we get in the main app on login from the intents extension. So this PR sets that up.
Test
OpenNoteIntentHandler.swiftand in line 28 add this code:Confirm that you see the token in the logs
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txtif the changes should be included in release notes. Include details about updating the notes in this section. For example:If the changes should not be included in release notes, add a statement to this section. For example: