-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin update fails if REST controller file has its constructor changed or is deleted #7464
Labels
category: devops
Features and tools supporting dev process.
focus: misc or unknown
Issues that need to be added to a focus area (aka "needs focus").
priority: medium
The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability
type: bug
The issue is a confirmed bug.
Comments
jessy-p
added
type: bug
The issue is a confirmed bug.
category: devops
Features and tools supporting dev process.
and removed
category: devops
Features and tools supporting dev process.
labels
Oct 12, 2023
More information here: paJDYF-aZa-p2 It's not just constructor arguments, it also affects us if the file was deleted. |
marcinbot
changed the title
Plugin update fails if constructor arguments have been updated
Plugin update fails if REST controller file has its constructor changed or is deleted
Oct 12, 2023
3 tasks
A similar situation happened when I deleted the file
|
haszari
added
the
focus: misc or unknown
Issues that need to be added to a focus area (aka "needs focus").
label
Mar 11, 2024
This was referenced Mar 19, 2024
6 tasks
For posterity: once this issue is fixed, we can revert #8728 |
This was referenced Apr 29, 2024
gpressutto5
added
the
priority: medium
The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability
label
May 1, 2024
6 tasks
Another delay caused by this issue in the 7.6.0 release. Maybe we can create a linter rule that fails if the constructor of a controller has been changed. |
6 tasks
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: devops
Features and tools supporting dev process.
focus: misc or unknown
Issues that need to be added to a focus area (aka "needs focus").
priority: medium
The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability
type: bug
The issue is a confirmed bug.
Describe the bug
When the WCPay plugin update is done, if it involves a code change where the arguments passed to a constructor have been changed, we get an error.
More details here: p1696877278872479-slack-CGGCLBN58
Actual behavior
Fatal error while updating the plugin with new version containing code changes
Expected behavior
Should be able to update the plugin without errors
Additional context
Please refer p1696877278872479-slack-CGGCLBN58
The text was updated successfully, but these errors were encountered: