misc: fix warning during plugin update due to problems with initialization #8728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
timur27
requested review from
a team and
gpressutto5
and removed request for
a team
gpressutto5
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
I don't like adding more methods to WC_Pament_Gateway_WCPay but I guess it is our only option until #7464 is resolved.
|
Agree @gpressutto5 I also don't like it and see it the only option for now. Another option would be to keep the duplicates detection logic within the controller, but this would also have its drawbacks and IMO they will be impacting more negatively compared to the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8731
Changes proposed in this Pull Request
#7464 describes the problem during plugin update when a new parameter is being added to the class's constructor during initialization. This PR is to fix one of the occurrences of this error, by removing the settings controller parameter and adding this parameter to be used through the gateway. Once #7464 is fixed, this PR should be reverted.
Testing instructions
7.5.3)WooCommerce -> Status -> Logs -> fatal errorsentry exists and contains theArgumentCountError: Too few arguments to function WC_REST_Payments_Settings_ControllerYour Site is Experiencing a Technical Issue7.5.3fix/fatals-on-plugin-update) [you can use this], use it to update the plugin on your store and confirm no more warnings during plugin updatefatal_errorssource underWooCommerce -> Status -> Logsbecause noArgumentCountErrorwas thrownnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge