Remove payouts rename notice overlay. #10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -26.9 kB (-2%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
nagpai
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
✅ - I did a manual test with the flag set to false and in develop - I was able to see the notice. On this branch the notice is gone, despite the flag being 0
Code changes look good to me. I have left a couple of non-blocking comments on wording of the changelog ( totally optional ), and the possibility of cleaning up the unwanted option from the local website DB.
| Significance: minor | ||
| Type: update | ||
|
|
||
| Remove the overlay that notices the rename from deposits to payouts. |
There was a problem hiding this comment.
Nitpick and optional:
Remove spotlight notice announcing rename of deposit to payout.
There was a problem hiding this comment.
| @@ -1923,7 +1923,6 @@ public static function add_wcpay_options_to_woocommerce_permissions_list( $permi | |||
| 'woocommerce_remind_me_later_todo_tasks', | |||
| 'woocommerce_deleted_todo_tasks', | |||
| 'wcpay_fraud_protection_welcome_tour_dismissed', | |||
| 'wcpay_payouts_rename_notice_dismissed', | |||
There was a problem hiding this comment.
Non-blocking: I was wondering if there is a way to clean up this option from the wp_options of the merchant website DB to keep it clean. Something using the delete_option
There was a problem hiding this comment.
Good question. If we do that, we'll leave a trail in the code that will do the deletion and if the user downgrades, the overlay will show up again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9704
Changes proposed in this Pull Request
Testing instructions
wcpay_payouts_rename_notice_dismisseddoesn't exist (rundelete_option( 'wcpay_payouts_rename_notice_dismissed' )on WP Console to delete that option).wcpay_payouts_rename_notice_dismisseddoes not exists.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge