-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental from profile session tag #43048
Conversation
Thank you for your contribution @pharring! We will review the pull request and get back to you soon. |
You are missing the needed permissions and public group memberships for an internal contributor. Please review the Azure SDK onboarding documentation and use the onboarding teams channel for any questions. Azure SDK onboarding (Microsoft internal) |
LGTM. Let me sync with Raj since he has more context on this. |
oteps is not a spec repository; it’s one step behind the spec. Initial ideas are discussed here, then they move to the spec. Should we remove the experimental flag based on this? |
@rajkumar-rangaraj looks like the original PR didn't update the Changelog. #41594 @pharring how would you like this feature described in our changelog? |
@TimothyMothra, I added a line in the CHANGELOG about removing the experimental suffix. As for documenting the original feature, is it OK to retro-actively add it to the CHANGELOG? Given the timeline, I think it would go in 1.1.0. |
@TimothyMothra looks like this missed the last beta. Can we get it in now? |
API change check API changes are not detected in this pull request. |
@pharring Review was pending on this question. |
Oh, I see. Sorry. |
The OpenTelemetry profiling data model spec has been merged: open-telemetry/oteps#239
This confirms the use of the "profile_id" tag to link from spans to profiles.
We can now drop the "_experimental" suffix from the tag we write in ProfilingSessionTraceProcessor.