Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental from profile session tag #43048

Closed
wants to merge 3 commits into from
Closed

Conversation

pharring
Copy link
Contributor

The OpenTelemetry profiling data model spec has been merged: open-telemetry/oteps#239
This confirms the use of the "profile_id" tag to link from spans to profiles.
We can now drop the "_experimental" suffix from the tag we write in ProfilingSessionTraceProcessor.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Distro Monitor OpenTelemetry Distro labels Mar 27, 2024
Copy link

Thank you for your contribution @pharring! We will review the pull request and get back to you soon.

@pallavit
Copy link
Contributor

@pharring:

You are missing the needed permissions and public group memberships for an internal contributor. Please review the Azure SDK onboarding documentation and use the onboarding teams channel for any questions.

Azure SDK onboarding (Microsoft internal)
Azure SDK onboarding assistance (Microsoft internal)
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@TimothyMothra
Copy link
Contributor

LGTM.

Let me sync with Raj since he has more context on this.
But this is a very small change, I think we can get this merged today.

@rajkumar-rangaraj
Copy link
Contributor

rajkumar-rangaraj commented Mar 28, 2024

The OpenTelemetry profiling data model spec has been merged: open-telemetry/oteps#239

oteps is not a spec repository; it’s one step behind the spec. Initial ideas are discussed here, then they move to the spec. Should we remove the experimental flag based on this?

@TimothyMothra
Copy link
Contributor

@rajkumar-rangaraj looks like the original PR didn't update the Changelog. #41594

@pharring how would you like this feature described in our changelog?

@pharring
Copy link
Contributor Author

@TimothyMothra, I added a line in the CHANGELOG about removing the experimental suffix. As for documenting the original feature, is it OK to retro-actively add it to the CHANGELOG? Given the timeline, I think it would go in 1.1.0.

@pharring
Copy link
Contributor Author

pharring commented May 2, 2024

@TimothyMothra looks like this missed the last beta. Can we get it in now?

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@rajkumar-rangaraj
Copy link
Contributor

The OpenTelemetry profiling data model spec has been merged: open-telemetry/oteps#239

oteps is not a spec repository; it’s one step behind the spec. Initial ideas are discussed here, then they move to the spec. Should we remove the experimental flag based on this?

@pharring Review was pending on this question.

@pharring
Copy link
Contributor Author

pharring commented May 2, 2024

Oh, I see. Sorry.

@pharring pharring closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Distro Monitor OpenTelemetry Distro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants