Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental from profile session tag #43048

Closed
wants to merge 3 commits into from
Closed

Remove experimental from profile session tag #43048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d009f30
Remove experimental from profile session tag
pharring Mar 27, 2024
0d529c8
Update CHANGELOG
pharring Mar 29, 2024
f26d69c
Merge branch 'main' into main
pharring May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Other Changes

* Removed the experimental suffix from the profile_id attribute. The profile_id attribute is added to spans when a profiling session is in progress.

## 1.2.0-beta.3 (2024-04-19)

### Features Added
Expand Down
5 changes: 2 additions & 3 deletions ...onitor.OpenTelemetry.AspNetCore/src/Internals/Profiling/ProfilingSessionTraceProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ internal sealed class ProfilingSessionTraceProcessor : BaseProcessor<Activity>
/// records the profiling session ID.
/// </summary>
/// <remarks>
/// Experimental until formalization of OTEP profiles data format.
/// See <see href="https://github.com/open-telemetry/oteps/pull/239" />.
/// See <see href="https://github.com/open-telemetry/oteps/blob/main/text/profiles/0239-profiles-data-model.md#from-other-signals-to-profiles" />.
/// </remarks>
internal const string TagName = "profile_id_experimental";
internal const string TagName = "profile_id";

private readonly ProfilingSessionEventSource _eventSource = ProfilingSessionEventSource.Current;

Expand Down