-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout rooms banner fix for react 17 and lower #5358
Breakout rooms banner fix for react 17 and lower #5358
Conversation
… when there is no breakout room state
Calling bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
Chat bundle size is increased❗.
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kfoidrcaaz.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
We should guard our components from returning undefined. However, there is only a draft PR to enforce it for eslint-plugin-react jsx-eslint/eslint-plugin-react#3750 |
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mygnprzvwh.chromatic.com/ |
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
2 similar comments
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
What
Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state because React versions lower that 18 will throw an error if components return undefined according to this discussion post reactwg/react-18#75
Why
Identity pass found this error on mobile form factor when joining a group call with the Call composite
How Tested
Tested local sample and used React 17 to confirm that no error is thrown.
Process & policy checklist
Is this a breaking change?