Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakout rooms banner fix for react 17 and lower #5358

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Breakout rooms banner fix for react 17 and lower #5358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49e0152
Fix BreakoutRoomsBanner component to return null instead of undefined…
mgamis-msft Oct 24, 2024
1b05350
Change files
mgamis-msft Oct 24, 2024
b0860e0
Merge branch 'main' into mgamis/breakout-rooms-banner-fix-for-react-1…
mgamis-msft Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-3770976d-8796-497c-b460-2f38b8b95e39.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Breakout rooms",
"comment": "Fix BreakoutRoomsBanner component to return null instead of undefined when there is no breakout room state",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions packages/react-composites/src/composites/CallComposite/components/BreakoutRoomsBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { Banner } from './Banner';
export const BreakoutRoomsBanner = (props: {
locale: CompositeLocale;
adapter: CommonCallAdapter;
}): JSX.Element | undefined => {
}): JSX.Element | null => {
const { locale, adapter } = props;

const assignedBreakoutRoom = useSelector(getAssignedBreakoutRoom);
Expand Down Expand Up @@ -61,5 +61,5 @@ export const BreakoutRoomsBanner = (props: {
</Stack>
);
}
return undefined;
return null;
};
Loading