Dev (#23)

* Fixing variable names for APP_VERSION * Env vars must start with REACT_APP_ Co-authored-by: Aurora Walker <[email protected]>
BattlesnakeOfficial · Mar 9, 2021 · 14afd32 · 14afd32
1 parent 9f27362
commit 14afd32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,7 +1,7 @@
 FROM node:10.19-alpine AS build
 
 ARG APP_VERSION
-ENV APP_VERSION=$APP_VERSION
+ENV REACT_APP_VERSION=$APP_VERSION
 
 COPY . .
 RUN npm ci

diff --git a/src/utils/engine-client.js b/src/utils/engine-client.js
@@ -5,7 +5,7 @@ import { isLastFrameOfGame } from "./game-state";
 
 const DEFAULT_SNAKE_HEAD = "default";
 const DEFAULT_SNAKE_TAIL = "default";
-const APP_VERSION = process.env.APP_VERSION;
+const APP_VERSION = process.env.REACT_APP_VERSION;
 
 async function get(url, query) {
   const response = await fetch(url + makeQueryString(query));
@@ -92,8 +92,8 @@ function isIllegalSvgPath(nameOrPath) {
 }
 
 function svgUrlFromName(base, relative) {
-  //appending the image tag of this version allows for cache busting on deploy
-  const extension = ".svg?boardVersion=" + APP_VERSION;
+  //appending the git hash of this version allows for cache busting on deploy
+  const extension = ".svg?board_version=" + APP_VERSION;
   return join("https://media.battlesnake.com", base, relative) + extension;
 }