Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(recoup) Spatial gridmap take 3 #10730

Merged
merged 23 commits into from
Aug 16, 2024

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Mar 12, 2024

Ports:

About The Pull Request

closes #11319

This PR optimizes the radio and searching through areas through the implementation of a new subsystem, SSspatial_grid.

This PR is a recoup of Mato0sz's #6582 2021 pr, with my own additional fixes and more tg fixes.

Why It's Good For The Game

bacon said it was good

kills massive radio overtime. Speed for our server (I need it for storage and smooth movement too)

Testing Photographs and Procedure

Screenshots&Videos

Screenshot 2024-07-09 182848

2 milliseconds pretty good!

Changelog

🆑 rkz, Kylerace, LemonInTheDark, Tastyfish, Mat05usz
code: Adds new subsystem to optimize radio and searching areas
/:cl:

Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

Hm. I should probably implement beauty element before this

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat Tsar-Salat marked this pull request as ready for review July 9, 2024 22:42
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Tsar-Salat
Copy link
Contributor Author

Dammit

Copy link

github-actions bot commented Aug 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Rukofamicom Rukofamicom added Test Merged This PR is currently in rotation Testmerge Passed Seemed fine in testmerge and removed Test Merged This PR is currently in rotation labels Aug 10, 2024
Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apparent issues during testmerge, but I would like a secondary code review by Bacon before slapping merge.

@Rukofamicom Rukofamicom added Needs Testmerge and removed Needs Testmerge Testmerge Passed Seemed fine in testmerge labels Aug 11, 2024
Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended TM uncovered a problem with camera listening, RKZ is already aware of it but making sure someone doesn't slap merge until it's fixed.

@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Aug 11, 2024

Extended TM uncovered a problem with camera listening

issue with eye_obj listening, fixed now.

Tested through spamming events and seeing if I could hear relayed speech "New announcement!" from the newscasters.

It did not fix it

@Tsar-Salat
Copy link
Contributor Author

image

There we go

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 16, 2024
Merged via the queue into BeeStation:master with commit 14b5b3c Aug 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't enable/disable Headset's channels
4 participants