[PORT] Follows up TG's atom_hud system

_maps/_basemap.dm

@@ -1,5 +1,4 @@
-//#define LOWMEMORYMODE //uncomment this to load centcom and runtime station and thats it.
-//#define QUICKSTART // uncomment this to start the round immidiately when ready and automatically spawn players with debug outfit
+#define LOWMEMORYMODE //uncomment this to load centcom and runtime station and thats it.
 
 // uncomment this for a map you need to use
 // #define FORCE_MAP "corgstation"

beestation.dme

@@ -59,6 +59,7 @@
 #include "code\__DEFINES\chat.dm"
 #include "code\__DEFINES\cinematics.dm"
 #include "code\__DEFINES\cleaning.dm"
+#include "code\__DEFINES\client.dm"
 #include "code\__DEFINES\clockcult.dm"
 #include "code\__DEFINES\clothing.dm"
 #include "code\__DEFINES\colors.dm"
@@ -207,6 +208,7 @@
 #include "code\__DEFINES\dcs\helpers.dm"
 #include "code\__DEFINES\dcs\signals.dm"
 #include "code\__DEFINES\dcs\signals\signals_area.dm"
+#include "code\__DEFINES\dcs\signals\signals_client.dm"
 #include "code\__DEFINES\dcs\signals\signals_global.dm"
 #include "code\__DEFINES\dcs\signals\signals_lighting.dm"
 #include "code\__DEFINES\dcs\signals\signals_movable.dm"

code/__DEFINES/client.dm

@@ -0,0 +1,2 @@
+/// necessary for set_eye() proc. This is used to compare a value
+#define CLIENT_OLD_EYE_NULL "I_AM_ACTUALLY_NULL" // Check 'mob login code' why it should be a thing

code/__DEFINES/dcs/signals/signals_client.dm

@@ -0,0 +1,8 @@
+// Format:
+// When the signal is called: (signal arguments)
+// All signals send the source datum of the signal as the first argument
+
+
+// /client signals
+/// from base of /client/proc/set_eye(), /atom/movable/proc/onTransitZ(): (old_z, new_z)
+#define COMSIG_CLIENT_EYE_Z_CHANGED "client_eye_z_changed"

code/__DEFINES/is_helpers.dm

@@ -9,6 +9,8 @@
 
 #define isdatum(thing) (istype(thing, /datum))
 
+#define isclient(thing) (istype(thing, /client))
+
 #define isweakref(D) (istype(D, /datum/weakref))
 
 #define isimage(thing) (istype(thing, /image))

code/__HELPERS/icon_smoothing.dm

@@ -258,8 +258,7 @@ DEFINE_BITFIELD(smoothing_junction, list(
 				match = target_turf
 
 	if(isnull(match) && smoothing_flags & SMOOTH_OBJ)
-		for(var/am in target_turf)
-			var/atom/movable/thing = am
+		for(var/atom/movable/thing as anything in target_turf)
 			if(!thing.anchored || isnull(thing.smoothing_groups))
 				continue
 			for(var/target in canSmoothWith)
@@ -417,21 +416,18 @@ DEFINE_BITFIELD(smoothing_junction, list(
 //Icon smoothing helpers
 /proc/smooth_zlevel(zlevel, now = FALSE)
 	var/list/away_turfs = block(locate(1, 1, zlevel), locate(world.maxx, world.maxy, zlevel))
-	for(var/V in away_turfs)
-		var/turf/T = V
-		if(T.smoothing_flags & (SMOOTH_CORNERS|SMOOTH_BITMASK))
+	for(var/turf/turf_to_smooth as anything in away_turfs)
+		if(turf_to_smooth.smoothing_flags & (SMOOTH_CORNERS|SMOOTH_BITMASK))
 			if(now)
-				T.smooth_icon()
+				turf_to_smooth.smooth_icon()
 			else
-				QUEUE_SMOOTH(T)
-		for(var/R in T)
-			var/atom/A = R
-			if(A.smoothing_flags & (SMOOTH_CORNERS|SMOOTH_BITMASK))
+				QUEUE_SMOOTH(turf_to_smooth)
+		for(var/atom/movable/movable_to_smooth as anything in turf_to_smooth)
+			if(movable_to_smooth.smoothing_flags & (SMOOTH_CORNERS|SMOOTH_BITMASK))
 				if(now)
-					A.smooth_icon()
+					movable_to_smooth.smooth_icon()
 				else
-					QUEUE_SMOOTH(A)
-
+					QUEUE_SMOOTH(movable_to_smooth)
 
 /atom/proc/clear_smooth_overlays()
 	cut_overlay(top_left_corner)

code/__HELPERS/roundend.dm

@@ -242,7 +242,7 @@
 	for(var/datum/atom_hud/antag/H in GLOB.huds)
 		for(var/m in GLOB.player_list)
 			var/mob/M = m
-			H.add_hud_to(M)
+			H.show_to(M)
 
 	CHECK_TICK
 

code/datums/components/anti_magic.dm

@@ -34,7 +34,7 @@
 		ADD_TRAIT(mob_parent, TRAIT_SEE_ANTIMAGIC, identifier)
 		var/image/forbearance = image('icons/effects/genetics.dmi', mob_parent, "servitude", MOB_OVERLAY_LAYER_ABSOLUTE(mob_parent.layer, MUTATIONS_LAYER))
 		forbearance.plane = mob_parent.plane
-		mob_parent.add_alt_appearance(/datum/atom_hud/alternate_appearance/basic/blessedAware, "magic_protection_[identifier]", forbearance)
+		mob_parent.add_alt_appearance(/datum/atom_hud/alternate_appearance/basic/blessed_aware, "magic_protection_[identifier]", forbearance)
 		mob_parent.update_alt_appearances()
 	else
 		return COMPONENT_INCOMPATIBLE
@@ -53,7 +53,7 @@
 	ADD_TRAIT(equipper, TRAIT_SEE_ANTIMAGIC, identifier)
 	var/image/forbearance = image('icons/effects/genetics.dmi', equipper, "servitude", MOB_OVERLAY_LAYER_ABSOLUTE(equipper.layer, MUTATIONS_LAYER))
 	forbearance.plane = equipper.plane
-	equipper.add_alt_appearance(/datum/atom_hud/alternate_appearance/basic/blessedAware, "magic_protection_[identifier]", forbearance)
+	equipper.add_alt_appearance(/datum/atom_hud/alternate_appearance/basic/blessed_aware, "magic_protection_[identifier]", forbearance)
 	equipper.update_alt_appearances()
 
 /datum/component/anti_magic/proc/on_drop(datum/source, mob/user)

code/datums/components/team_monitor.dm

@@ -447,7 +447,7 @@ GLOBAL_LIST_EMPTY(tracker_beacons)
 		UnregisterSignal(updating, COMSIG_MOVABLE_MOVED)
 
 	//Goodbye, it was a good life
-	remove_from_huds()
+	remove_atom_from_huds()
 
 	//Remove from the global network
 	if(team_frequency)
@@ -503,7 +503,7 @@ GLOBAL_LIST_EMPTY(tracker_beacons)
 	if((updating || always_update) && visible)
 		add_to_huds()
 	else
-		remove_from_huds()
+		remove_atom_from_huds()
 
 //===========
 // Position Updating
@@ -526,7 +526,7 @@ GLOBAL_LIST_EMPTY(tracker_beacons)
 //===========
 
 //Remove ourselves from other tracking components
-/datum/component/tracking_beacon/proc/remove_from_huds()
+/datum/component/tracking_beacon/proc/remove_atom_from_huds()
 	if(!team_frequency)
 		return
 	for(var/datum/component/team_monitor/team_monitor as() in get_all_watchers_on_frequency(team_frequency, team_freq_key, global_signal))

code/datums/elements/digital_camo.dm

@@ -43,24 +43,24 @@
 			//Hide the mob
 			silicon.client.images |= attached_mobs[target]
 			//Hide from HUD
-			var/datum/atom_hud/M = GLOB.huds[silicon.med_hud]
-			var/datum/atom_hud/S = GLOB.huds[silicon.sec_hud]
-			M.hide_single_atomhud_from(silicon, target)
-			S.hide_single_atomhud_from(silicon, target)
+			var/datum/atom_hud/med_hud = GLOB.huds[silicon.med_hud]
+			var/datum/atom_hud/sec_hud = GLOB.huds[silicon.sec_hud]
+			med_hud.hide_single_atomhud_from(silicon, target)
+			sec_hud.hide_single_atomhud_from(silicon, target)
 
 /datum/element/digital_camo/proc/HideFromSiliconHuds(mob/living/target)
 	for(var/mob/living/silicon/silicon as() in GLOB.silicon_mobs)
-		var/datum/atom_hud/M = GLOB.huds[silicon.med_hud]
-		var/datum/atom_hud/S = GLOB.huds[silicon.sec_hud]
-		M.hide_single_atomhud_from(silicon, target)
-		S.hide_single_atomhud_from(silicon, target)
+		var/datum/atom_hud/med_hud = GLOB.huds[silicon.med_hud]
+		var/datum/atom_hud/sec_hud = GLOB.huds[silicon.sec_hud]
+		med_hud.hide_single_atomhud_from(silicon, target)
+		sec_hud.hide_single_atomhud_from(silicon, target)
 
 /datum/element/digital_camo/proc/UnhideFromSiliconHuds(mob/living/target)
 	for(var/mob/living/silicon/silicon as() in GLOB.silicon_mobs)
-		var/datum/atom_hud/M = GLOB.huds[silicon.med_hud]
-		var/datum/atom_hud/S = GLOB.huds[silicon.sec_hud]
-		M.unhide_single_atomhud_from(silicon, target)
-		S.unhide_single_atomhud_from(silicon, target)
+		var/datum/atom_hud/med_hud = GLOB.huds[silicon.med_hud]
+		var/datum/atom_hud/sec_hud = GLOB.huds[silicon.sec_hud]
+		med_hud.unhide_single_atomhud_from(silicon, target)
+		sec_hud.unhide_single_atomhud_from(silicon, target)
 
 /datum/element/digital_camo/proc/on_examine(datum/source, mob/user, list/examine_list)
 	SIGNAL_HANDLER

code/datums/helper_datums/teleport.dm

@@ -282,7 +282,7 @@ CREATION_TEST_IGNORE_SUBTYPES(/obj/effect/temp_visual/teleportation_wake)
 	src.destination = destination
 	prepare_huds()
 	for(var/datum/atom_hud/data/diagnostic/diag_hud in GLOB.huds)
-		diag_hud.add_to_hud(src)
+		diag_hud.add_atom_to_hud(src)
 	var/image/holder = hud_list[DIAG_WAKE_HUD]
 	var/mutable_appearance/MA = new /mutable_appearance()
 	MA.icon = 'icons/effects/effects.dmi'
@@ -295,7 +295,7 @@ CREATION_TEST_IGNORE_SUBTYPES(/obj/effect/temp_visual/teleportation_wake)
 /obj/effect/temp_visual/teleportation_wake/Destroy()
 	if (has_hud_icon)
 		for(var/datum/atom_hud/data/diagnostic/diag_hud in GLOB.huds)
-			diag_hud.remove_from_hud(src)
+			diag_hud.remove_atom_from_hud(src)
 	return ..()
 
 /obj/effect/temp_visual/portal_opening