[PORT] Follows up TG's atom_hud system #10897
Open
+870
−422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Main PR tgstation/tgstation#65189 * Additional PRS * tgstation/tgstation#65604 * tgstation/tgstation#81338
EvilDragonfiend
added
Priority: Critical
EvilDragonfiend
force-pushed
the
portatomhud
branch
from
90a950f to
6bcd034
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
ah, actually it was fine to review |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Crossedfall
reviewed
Dec 10, 2024
|
De-TM for now. I figured atom hud issue, I guess. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Follows up TG's atom_hud system
Hud Image Culling By Z Level: Theft edition tgstation/tgstation#65189
Optimizes changing z level as a ghost by something like 85% tgstation/tgstation#73005
Fixes runtimes off bad indexes, and adding null to client images tgstation/tgstation#73267
IMPORTANT: dependency
big amount of images being dumped into
client/list/imageshas been an issue causing a lot of maptick.This PR ports their atom_hud that prevents things being injected into a client needlessly when they can't see stuff from another z level
show_to(mob)is easier to understand thanadd_hud_to(mob)add_atom_to_hud()thanadd_to_hud()remove_atom_from_hud()thanremove_from_hud(). it might be correct, but it's confusing grammarly.remove SOMETHING from somewhereis grammarly correct, so TG changed it toremove_atom_from_hud(). I am happy with it too.hide_from()thanremove_hud_from()show_to(mob)<-add_hud_to(mob)add_atom_to_hud()<-add_to_hud()hide_from()<-remove_hud_from()remove_atom_from_hud()<-remove_from_hud()MorSfor med_hud and sec_hud is a bad arbitrary usecase. We'd thinkMis an arbitrary var name for mob, not med_hud, and others too.H(as hud) isn't that nice tooWhy It's Good For The Game
Greatly good for performance
Testing Photographs and Procedure
Screenshots&Videos
previously, it's 300 images
now it's cull down to 19 images
fine all as normal status
Changelog
🆑 LemonInTheDark, MrMelbert, SmArtKar, RandomGamer123, Sealed101 (Port by EvilDragon)
code: improved atom_hud system to greatly improve performance for maptick, with bug fix PRs along
fix: fixed some circuit overlay issues
code: You can see HUD through camera even with the up-to-date HUD system. (by EvilDragonfiend)
/:cl: