Revert "Fixes weather's bad image rendering code" #10902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dea0bd7.
|
dunno why that pr was merged in the first place because there is nothing wrong with changing area icons/icon states |
changing area's icon_state is wrong in weather datum. It means you don't get multiple weather sprites when multiple weathers exist. (I answered that in Discord, but leaving here too since people might wonder the same)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10775
Radstorms are completely broken.
🆑
del: Reverts a PR fixing weathers bad image rendering code, since it breaks the rendering of weather.
/:cl: