Fixes weather rendering very correctly #10904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilDragonfiend
commented
Apr 19, 2024
Comment on lines
-484
to
-493
| /area/update_icon_state() | ||
| var/weather_icon | ||
| for(var/V in SSweather.processing) | ||
| var/datum/weather/W = V | ||
| if(W.stage != END_STAGE && (src in W.impacted_areas)) | ||
| W.update_areas() | ||
| weather_icon = TRUE | ||
| if(!weather_icon) | ||
| icon_state = null | ||
| return ..() |
There was a problem hiding this comment.
This is called every time APC power state is changed, and that's the reason why areas have additional weather appearance.
This also does wrong with the old weather code too. It should be definitely gone.
PowerfulBacon
approved these changes
May 8, 2024
ss13-beebot
added a commit
that referenced
this pull request
May 8, 2024
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
* Fixes weather code * Make var private * Better code * More comment and private_var * for loop optimisation * Verbose comment
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Actual issue was because
update_areas()proc is called by something, while it shouldn't be called by againWhy It's Good For The Game
Bug fix
Testing Photographs and Procedure
This is the exact case having multiple call of
update_areas(), and I figured the bug was caused by that.https://youtu.be/-l55ncuXaSc
Fix video for heretic void weather
Changelog
🆑
code: Refactored weather code and fixed weather bad rendering issue.
fix: Void Heretic no longer shows void weather where they don't stand on.
/:cl: