Fixes weather's bad image rendering code #10775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rukofamicom
approved these changes
Apr 15, 2024
ss13-beebot
added a commit
that referenced
this pull request
Apr 15, 2024
PowerfulBacon
added a commit
that referenced
this pull request
Apr 18, 2024
This reverts commit dea0bd7.
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
* weather fix * comment
DrDuckedGoose
pushed a commit
to DrDuckedGoose/BeeStation-Hornet
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
hopefully fixes it.
I am not sure why that happens, but I think the code is slow because it directly changes dmi and icon state, and even the code tries to change even if there's no necessary to update.
NOTE
Why It's Good For The Game
bugfix
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
code: slightly improved weather datum. This may fix a bug that weathers (radiation storm*) are rendered incorrectly.
/:cl: