Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revival] Ports the smart pipes mapping helper #11274

Merged
merged 11 commits into from
Aug 6, 2024

Conversation

mystery3525
Copy link
Contributor

@mystery3525 mystery3525 commented Aug 1, 2024

About The Pull Request

Ports:

Additionally stomps some bugs and oversights in the original PR. Added runtime detection for multiple conflicting pipe spawners on a single tile. No more two pipes for a 90 degree turn.

Added a new "supply_scrubber" helper type which automatically does the functions of both the supply pipe and scrubbers pipes on the correct layers!

Some nitpick improvements in check_grep.sh (Run Linters task), added a sanity check for simple_pipes and regular atmospheric machines on top of each other.

Why It's Good For The Game

This is a runtime-based helper that mappers can choose to implement to make things easier when dealing with piping and dirs, primarily targeting the air supply and distro pipes around the station. Adding more features for mappers with low impact is good I think. I do not like /tg/'s smart pipes, you still have manual control In-Character.

WARNING: Do NOT use these for precision applications such as the SM or atmos, you'll have pipes connecting when they are not supposed to.

Testing Photographs and Procedure

Screenshots&Videos

In map editor

image

image

image

In game

image

image

(pipes un-hidden for visual effect)
image

Linter changes

image

Example: It found a singular duplicate pipe on BoxStation:

image

Changelog

🆑 EdgeLordExe ported and fixed by mystery3525 with help from BriggsIDP
add: Added new smart pipes mapping helper
add: Added new smart pipes air supply/scrubbers pipe helper
add: Added sanity checks for the pipes mapping helper
add: Updated Runtimestation to use the supply_scrubbers helper
fix: Fixed found issues relating to smart pipes
/:cl:

@mystery3525 mystery3525 requested a review from a team as a code owner August 1, 2024 00:15
@mystery3525 mystery3525 changed the title Pipe helpers take 2 [Revival] Ports the smart pipes mapping helper Aug 1, 2024
@github-actions github-actions bot added Mapping DMM Change Sprites labels Aug 1, 2024
Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to be against these for some reason, but they would be far easier for mapping pipes, so its a no-brainer really

Copy link

github-actions bot commented Aug 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 6, 2024
Merged via the queue into BeeStation:master with commit cd22a2d Aug 6, 2024
8 checks passed
@mystery3525 mystery3525 deleted the pipe-helpers-take-2 branch August 7, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants