-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Revival] Ports the smart pipes mapping helper #11274
Merged
PowerfulBacon
merged 11 commits into
BeeStation:master
from
mystery3525:pipe-helpers-take-2
Aug 6, 2024
Merged
[Revival] Ports the smart pipes mapping helper #11274
PowerfulBacon
merged 11 commits into
BeeStation:master
from
mystery3525:pipe-helpers-take-2
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mystery3525
changed the title
Pipe helpers take 2
[Revival] Ports the smart pipes mapping helper
Aug 1, 2024
PowerfulBacon
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used to be against these for some reason, but they would be far easier for mapping pipes, so its a no-brainer really
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports:
Additionally stomps some bugs and oversights in the original PR. Added runtime detection for multiple conflicting pipe spawners on a single tile. No more two pipes for a 90 degree turn.
Added a new "supply_scrubber" helper type which automatically does the functions of both the supply pipe and scrubbers pipes on the correct layers!
Some nitpick improvements in
check_grep.sh
(Run Linters task), added a sanity check for simple_pipes and regular atmospheric machines on top of each other.Why It's Good For The Game
This is a runtime-based helper that mappers can choose to implement to make things easier when dealing with piping and dirs, primarily targeting the air supply and distro pipes around the station. Adding more features for mappers with low impact is good I think. I do not like /tg/'s smart pipes, you still have manual control In-Character.
WARNING: Do NOT use these for precision applications such as the SM or atmos, you'll have pipes connecting when they are not supposed to.
Testing Photographs and Procedure
Screenshots&Videos
In map editor
In game
(pipes un-hidden for visual effect)
Linter changes
Example: It found a singular duplicate pipe on BoxStation:
Changelog
🆑 EdgeLordExe ported and fixed by mystery3525 with help from BriggsIDP
add: Added new smart pipes mapping helper
add: Added new smart pipes air supply/scrubbers pipe helper
add: Added sanity checks for the pipes mapping helper
add: Updated Runtimestation to use the supply_scrubbers helper
fix: Fixed found issues relating to smart pipes
/:cl: