Added signals to attack_ai(), attack_robot(), and interact()

code/__DEFINES/dcs/signals/signals_atom/signals_atom_attack.dm

@@ -8,6 +8,8 @@
 	#define COMPONENT_NO_AFTERATTACK (1<<0)
 ///from base of atom/attack_hulk(): (/mob/living/carbon/human)
 #define COMSIG_ATOM_HULK_ATTACK "hulk_attack"
+///from base of atom/attack_ai(): (/mob/user)
+#define COMSIG_ATOM_ATTACK_AI "attack_ai"
 ///from base of atom/animal_attack(): (/mob/user)
 #define COMSIG_ATOM_ATTACK_ANIMAL "attack_animal"
 //from base of atom/attack_basic_mob(): (/mob/user)
@@ -25,3 +27,5 @@
 #define COMSIG_ATOM_ATTACK_HAND "atom_attack_hand"
 ///from base of atom/attack_paw(): (mob/user)
 #define COMSIG_ATOM_ATTACK_PAW "atom_attack_paw"
+///from base of atom/attack_robot(): (mob/user)
+#define COMSIG_ATOM_ATTACK_ROBOT "atom_attack_robot"

code/__DEFINES/dcs/signals/signals_obj/signals_item/signals_item.dm

@@ -54,6 +54,11 @@
 
 #define COMSIG_ITEM_ATTACK_EFFECT "item_effect_attacked"
 
+///from the base of obj/item/proc/GetAccess(): ()
+#define COMSIG_ITEM_GET_ACCESS "item_get_access"
+///from the base of obj/item/proc/GetID(): ()
+#define COMSIG_ITEM_GET_ID "item_get_id"
+
 //////////////////////////////
 
 // /obj/effect/mine signals

code/_onclick/ai.dm

@@ -95,7 +95,9 @@
 	A.attack_ai(src)
 
 /atom/proc/attack_ai(mob/user)
-	return
+	if(SEND_SIGNAL(src, COMSIG_ATOM_ATTACK_AI, user) & COMPONENT_CANCEL_ATTACK_CHAIN)
+		return TRUE
+	return FALSE
 
 /*
 	Since the AI handles shift, ctrl, and alt-click differently

code/_onclick/cyborg.dm

@@ -182,5 +182,6 @@
 	A.attack_robot(src)
 
 /atom/proc/attack_robot(mob/user)
-	attack_ai(user)
-	return
+	if(SEND_SIGNAL(src, COMSIG_ATOM_ATTACK_ROBOT, user) & COMPONENT_CANCEL_ATTACK_CHAIN)
+		return TRUE
+	return FALSE

code/game/machinery/_machinery.dm

@@ -462,6 +462,9 @@ Class Procs:
 		user.visible_message("<span class='danger'>[user] smashes [src] with [user.p_their()] paws[damage ? "." : ", without leaving a mark!"]</span>", null, null, COMBAT_MESSAGE_RANGE)
 
 /obj/machinery/attack_robot(mob/user)
+	. = ..()
+	if(.)
+		return
 	if(!(interaction_flags_machine & INTERACT_MACHINE_ALLOW_SILICON) && !IsAdminGhost(user))
 		return FALSE
 	if(Adjacent(user) && can_buckle && has_buckled_mobs()) //so that borgs (but not AIs, sadly (perhaps in a future PR?)) can unbuckle people from machines
@@ -475,6 +478,9 @@ Class Procs:
 	return _try_interact(user)
 
 /obj/machinery/attack_ai(mob/user)
+	. = ..()
+	if(.)
+		return
 	if(!(interaction_flags_machine & INTERACT_MACHINE_ALLOW_SILICON) && !IsAdminGhost(user))
 		return FALSE
 	if(iscyborg(user))// For some reason attack_robot doesn't work

code/game/objects/items.dm

@@ -538,6 +538,9 @@ GLOBAL_VAR_INIT(rpg_loot_items, FALSE)
 	attack_paw(A)
 
 /obj/item/attack_ai(mob/user)
+	. = ..()
+	if(.)
+		return
 	if(istype(src.loc, /obj/item/robot_module))
 		//If the item is part of a cyborg module, equip it
 		if(!iscyborg(user))

code/modules/jobs/access.dm

@@ -45,10 +45,10 @@
 			return TRUE
 
 /obj/item/proc/GetAccess()
-	return list()
+	. = SEND_SIGNAL(src, COMSIG_ITEM_GET_ACCESS) || list()
 
 /obj/item/proc/GetID()
-	return null
+	. = SEND_SIGNAL(src, COMSIG_ITEM_GET_ID)
 
 /obj/item/proc/RemoveID()
 	return null