Added signals to attack_ai(), attack_robot(), and interact() #11306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mystery3525
changed the title
mystery3525
commented
Aug 7, 2024
mystery3525
changed the title
6 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
PowerfulBacon
approved these changes
Oct 11, 2024
|
Is this the PR that broke machines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Added Signal Handling for
/atom/proc/attack_ai(),/atom/proc/attack_robot, and/atom/proc/interact(). Prerequisite atomization for my ModPC refactor. I also made/obj/item/attack_ai()and/obj/machinery/attack_ai()call its parent so that my future refactor will work, but we may want to do a refactor where we add SHOULD_CALL_PARENT(TRUE) to all the component-related attack_*() procs.Requires: #11310
Why It's Good For The Game
Having signals be an option increases our abilities to do more interesting things. Also is a prerequisite to my ModPC Componentization Refactor.
Testing Photographs and Procedure
Screenshots&Videos
It compiles
attacking as AI still works
Camera bug still works
Guitar still works
Changelog
🆑
code: Added signal handlers for attack_ai(), attack_robot(), and interact()
/:cl: