Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lavaland syndicate station's explosives being able to be picked up #12033

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

XeonMations
Copy link
Contributor

@XeonMations XeonMations commented Dec 14, 2024

About The Pull Request

Makes the actual explosives a subtype, as well as making it so they cant be picked up.

Why It's Good For The Game

no free explosives for you, lavaland

Testing Photographs and Procedure

Screenshots&Videos
2024-12-14.14-00-08.mp4
2024-12-14.14-00-42.mp4

Changelog

🆑 XeonMations
fix: The syndicate lavaland base's explosives are no longer able to be picked up.
/:cl:

@Fronsis
Copy link

Fronsis commented Dec 14, 2024

Hm, aren't a few payloads missing? iirc the whole base is supposed to be engulfed entirely in flames rather than just half of the base (based on the last second of your view range on the 2nd video)

@XeonMations
Copy link
Contributor Author

Hm, aren't a few payloads missing? iirc the whole base is supposed to be engulfed entirely in flames rather than just half of the base (based on the last second of your view range on the 2nd video)

I dunno. I did not change the mapping at all. I just made them invisibile to the player ingame.

code/game/turfs/closed/wall/mineral_walls.dm Outdated Show resolved Hide resolved
Comment on lines +402 to +406
// Special bomb core for inside the lavaland syndicate base walls. Players should not be able to interact with this.
/obj/item/bombcore/large/syndicate_base
installed = TRUE
anchored = TRUE
invisibility = INVISIBILITY_OBSERVER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually needed if the bombcore is force moved inside the wall anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it does still appear in the context menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants