Add playtime support for removed jobs #9893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
TGUI-Changes
Penwin0
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Jobs can now be removed but will show in the playtime report as (Removed).
Developed for #9817
Why It's Good For The Game
Removing historical data from being visible to the player is unhelpful. This also prevents loss of access to roles based on their removal (losing access to CMO due to removal of viro hours, for example)
Testing Photographs and Procedure
Screenshots&Videos
Tested by removing virologist from the code and adding 100min of playtime in the database.
Changelog
🆑
code: Added code support for the ability to view playtime of removed jobs.
/:cl: