Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a small vignette that pops up when your laws are changed as AI. #9939

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

Liver-1
Copy link
Contributor

@Liver-1 Liver-1 commented Oct 1, 2023

About The Pull Request

Adds a small vignette that appears momentarily on the screen when laws are changed.
The vignette appears and then immediately fades out, similar to other notifier vignettes.
Created as a result of the following discussion on the forums:
https://forums.beestation13.com/t/please-can-we-make-law-changes-more-obvious-as-ai/

Happy to alter the actual style of the vignette if necessary, but just remember it's only meant to flash up momentarily on the screen!

Why It's Good For The Game

Because AIs should change their behaviour immediately upon getting a law change, and sometimes they happen to be focusing on the game window rather than the chat window while playing.
This very minor alteration will not disrupt game flow in the slightest, whilst making it even harder to miss the law changes.

"Played a lot of AI, and I still would miss law changes from time to time, sometimes on highpop the chat goes so quick that if you don’t pay attention to it for a few seconds because you’re in a shell for instance, you just end up missing it..." - Haliris

"What if there was just a big annyoing pop up for law changes
it’d suck ass when theres lots of rapid law changes but as AI players arent we masochists anyways?" - llol111

Testing Photographs and Procedure

Hard to screenshot it to be honest because it pops up then immediately disappears, but it looks like this:
image

And the raw file looks like this:
lawchangevignette_red

Edit: Added video at request:

dreamseeker_bmxn27ZsmW.mp4

Changelog

🆑
add: Added a vignette that appears momentarily when your laws are changed as AI.
imageadd: added the "law_change" fullscreen vignette.
/:cl:

@Tsar-Salat
Copy link
Contributor

Hard to screenshot it to be honest because it pops up then immediately disappears, but it looks like this:

It would be more appropriate to video this. I recommend a program like ShareX, as it works exactly like Windows Snip or PrnrScrn, but for videos.

@PowerfulBacon
Copy link
Member

Oh, that overlay is pretty sick. Feels like it should flicker different text or vibrate somehow but that feels like too much to reasonably ask

@Liver-1
Copy link
Contributor Author

Liver-1 commented Oct 2, 2023

Oh, that overlay is pretty sick. Feels like it should flicker different text or vibrate somehow but that feels like too much to reasonably ask

Something for a future PR I think. I like that idea too.

@Liver-1
Copy link
Contributor Author

Liver-1 commented Oct 2, 2023

Hard to screenshot it to be honest because it pops up then immediately disappears, but it looks like this:

It would be more appropriate to video this. I recommend a program like ShareX, as it works exactly like Windows Snip or PrnrScrn, but for videos.

Video added. ShareX is easy to use, thanks for the recommendation.

@Rukofamicom Rukofamicom added this pull request to the merge queue Oct 3, 2023
Merged via the queue into BeeStation:master with commit b19e03a Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants