Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] TGUI Chores #2543

Merged
merged 3 commits into from
Oct 14, 2023
Merged

[Upstream] TGUI Chores #2543

merged 3 commits into from
Oct 14, 2023

Conversation

Bobbanz1
Copy link
Contributor

About The Pull Request

Pulls from upstream the following PR:

Main changes from that PR:

  • Changes TGUI Byond/winset/sendmessage/windowID API
  • Windows will now use the bootstrapped vendor nodejs instead of the system nodejs, this should improve development consistency and stability.
  • Uses x64 nodejs binaries, this will fix out of memory issues when using the vendor nodejs
  • Removes the "caniuse-lite" browserslist warning.
  • Refactors asset loading.

Why It's Good For The Game

Keeps this stuff somewhat up to date, also used in a future PR.

Testing Photographs and Procedure

Screenshots&Videos TGUI window works

Skärmbild 2023-09-22 084756

Changelog

🆑itsmeow, stylemistake, willox, Bizzonium, AnturK
code: Updated development-side TGUI bootstrapping, updated internal TGUI API
fix: Fixed some bugs related to TGUI Boxes not computing class names properly.
refactor: Refactored TGUI asset loading.
/:cl:

@Bobbanz1
Copy link
Contributor Author

Bobbanz1 commented Sep 22, 2023

oh god oh fuck

It's completely identical...why is it screaming?

@Bobbanz1
Copy link
Contributor Author

Why did that version work but the previous one didn't?!

@Bokkiewokkie Bokkiewokkie added Update PRs that pull updates from upstream Active Test Merge labels Sep 22, 2023
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If bee approved it it's probably fiiiine

@Bokkiewokkie Bokkiewokkie merged commit deeca63 into BeeStation:master Oct 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge TGUI-Changes tools Update PRs that pull updates from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants