Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Refactor the Parameter Keys to make them consistent and easy to learn #874

Conversation

imikejackson
Copy link
Contributor

No description provided.

@imikejackson imikejackson marked this pull request as draft February 29, 2024 23:05
@imikejackson imikejackson force-pushed the feature/update_parameter_keys branch 2 times, most recently from 91e303e to dff9857 Compare March 6, 2024 15:24
@imikejackson imikejackson force-pushed the feature/update_parameter_keys branch 5 times, most recently from e5ff3ce to c73b711 Compare March 15, 2024 01:22
@imikejackson imikejackson force-pushed the feature/update_parameter_keys branch 4 times, most recently from 141368f to e4ba606 Compare March 31, 2024 15:01
@imikejackson imikejackson force-pushed the feature/update_parameter_keys branch from e4ba606 to 2334974 Compare April 3, 2024 12:55
@imikejackson imikejackson force-pushed the feature/update_parameter_keys branch 3 times, most recently from c5ee198 to a57df57 Compare April 12, 2024 13:27
@imikejackson imikejackson marked this pull request as ready for review April 12, 2024 21:30
@imikejackson imikejackson requested a review from JDuffeyBQ April 12, 2024 21:30
About 75 left to do..

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
68 tests still failing.

Signed-off-by: Michael Jackson <[email protected]>
Down to the python codes

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
@JDuffeyBQ JDuffeyBQ force-pushed the feature/update_parameter_keys branch from d0ccf32 to 39b4132 Compare April 17, 2024 15:44
Signed-off-by: Michael Jackson <[email protected]>
Checks for _path, _name, 's' for parameter types

Signed-off-by: Michael Jackson <[email protected]>
@imikejackson imikejackson force-pushed the feature/update_parameter_keys branch from fcce111 to 417efd4 Compare April 18, 2024 17:53
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
@imikejackson imikejackson merged commit 3f44f31 into BlueQuartzSoftware:develop Apr 19, 2024
8 checks passed
@imikejackson imikejackson deleted the feature/update_parameter_keys branch April 19, 2024 13:02
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
…learn (BlueQuartzSoftware#874)

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Co-authored-by: Jared Duffey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants