Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Refactor the Parameter Keys to make them consistent and easy to learn #874

Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
97a1179
ENH: Refactor the Parameter Keys to make them consistent and easy to …
imikejackson Feb 29, 2024
53dac1b
Updated more parameter constant variable names and values
imikejackson Mar 15, 2024
5a02fac
Start fixing unit tests
imikejackson Mar 15, 2024
d1b6e8e
Last batch of changes. I think.
imikejackson Apr 10, 2024
08aedbf
Add warnings if Parameter keys are miss-matched from incoming json
imikejackson Apr 10, 2024
b03e2e7
Fixing unit tests.
imikejackson Apr 10, 2024
4c056e2
All prebuilt pipelines should be passing.
imikejackson Apr 11, 2024
0283c4b
Python scripts updated
imikejackson Apr 11, 2024
13f85b2
More unit test fixes
imikejackson Apr 11, 2024
07951c4
Update parameter keys for consistency
imikejackson Apr 11, 2024
f2bf8db
Iterative Closest Point parameter key update
imikejackson Apr 11, 2024
5c05c27
ENH: Add a timestamp() function to return a timestamp string
imikejackson Apr 11, 2024
4c92db0
VER: Update to 1.3.0 because of the API breakage
imikejackson Apr 11, 2024
33f5854
ENH: Add timestamps to more outputs from CliObserver
imikejackson Apr 11, 2024
0c281ad
Remove file to get testing to work properly.
imikejackson Apr 12, 2024
2f3b35d
ENH: Enhance error messages from ValidateDirectoryWritePermission()
imikejackson Apr 12, 2024
e6a2139
Fix pipeline
imikejackson Apr 12, 2024
c2909f1
Fix logic error in FileUtilities::ValidateDirectoryWritePermission
imikejackson Apr 12, 2024
39b4132
Moved FindBestMatches to StringUtilities.hpp
JDuffeyBQ Apr 17, 2024
2ec1c1e
Adjust warning output style
imikejackson Apr 17, 2024
8c107e6
nxrunner emits json pipeline warnings on preflight
imikejackson Apr 17, 2024
173e272
TEST: Add unit test to check for proper parameter key values.
imikejackson Apr 17, 2024
417efd4
Update ChoicesParameters to use _index
imikejackson Apr 18, 2024
472d537
Remove debugging info
imikejackson Apr 18, 2024
e5a5b22
Remove debug output from sphinx docs generation
imikejackson Apr 18, 2024
0b1535b
Fix failing unit test
imikejackson Apr 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ endif()
file(TO_CMAKE_PATH "${CMAKE_COMMAND}" CMAKE_COMMAND_NORM)

project(simplnx
VERSION 1.2.7
VERSION 1.3.0
DESCRIPTION "SIMPL Redesign"
HOMEPAGE_URL "https://github.com/bluequartzsoftware/simplnx"
LANGUAGES CXX
Expand Down
2 changes: 1 addition & 1 deletion conda/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% set name = "simplnx" %}
{% set version = "1.2.7" %}
{% set version = "1.3.0" %}

package:
name: {{ name|lower }}
Expand Down
2 changes: 1 addition & 1 deletion conda/recipe.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
context:
version: "1.2.7"
version: "1.3.0"
name: simplnx

package:
Expand Down
48 changes: 24 additions & 24 deletions pipelines/Combo-EBSD-osc_r0c0.d3dpipeline
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"args": {
"cell_attribute_matrix_name": "CellData",
"cell_ensemble_attribute_matrix_name": "CellEnsembleData",
"data_container_name": "DataContainer",
"output_image_geometry_path": "DataContainer",
"input_file": "Data/OrientationAnalysis/Combo-EBSD-120130.osc_r0c0.ang"
},
"comments": "",
Expand All @@ -19,7 +19,7 @@
},
{
"args": {
"created_image_geometry": "",
"output_image_geometry_path": "",
"remove_original_geometry": true,
"rotate_slice_by_slice": false,
"rotation_axis": [
Expand Down Expand Up @@ -55,7 +55,7 @@
]
],
"rotation_representation": 0,
"selected_image_geometry": "DataContainer"
"input_image_geometry_path": "DataContainer"
},
"comments": "",
"filter": {
Expand Down Expand Up @@ -83,7 +83,7 @@
},
{
"args": {
"array_thresholds": {
"array_thresholds_object": {
"inverted": false,
"thresholds": [
{
Expand All @@ -98,7 +98,7 @@
"type": "collection",
"union": 0
},
"created_data_path": "Mask"
"output_data_array_name": "Mask"
},
"comments": "",
"filter": {
Expand Down Expand Up @@ -132,7 +132,7 @@
"args": {
"file_name": "Data/Output/Examples/Combo-EBSD-osc_r0c0.png",
"image_array_path": "DataContainer/CellData/IPFColors",
"image_geom_path": "DataContainer",
"input_image_geometry_path": "DataContainer",
"index_offset": 0,
"plane": 0
},
Expand Down Expand Up @@ -165,7 +165,7 @@
"crystal_structures_array_path": "DataContainer/CellEnsembleData/CrystalStructures",
"feature_ids_array_name": "FeatureIds",
"mask_array_path": "DataContainer/CellData/Mask",
"image_geometry_path": "DataContainer",
"input_image_geometry_path": "DataContainer",
"misorientation_tolerance": 5.0,
"quats_array_path": "DataContainer/CellData/Quats",
"randomize_feature_ids": true,
Expand All @@ -181,7 +181,7 @@
{
"args": {
"avg_c_axes_array_path": "AvgCAxes",
"cell_feature_attribute_matrix": "DataContainer/CellFeatureData",
"cell_feature_attribute_matrix_path": "DataContainer/CellFeatureData",
"cell_phases_array_path": "DataContainer/CellData/Phases",
"crystal_structures_array_path": "DataContainer/CellEnsembleData/CrystalStructures",
"feature_ids_array_path": "DataContainer/CellData/FeatureIds",
Expand All @@ -203,7 +203,7 @@
"feature_ids_array_path": "DataContainer/CellData/FeatureIds",
"feature_reference_c_axis_misorientations_array_name": "FeatureRefCAxisMisorientation",
"feature_stdev_c_axis_misorientations_array_name": "StdevCAxisMisorientation",
"image_geometry_path": "DataContainer",
"input_image_geometry_path": "DataContainer",
"quats_array_path": "DataContainer/CellData/Quats"
},
"comments": "",
Expand All @@ -230,7 +230,7 @@
{
"args": {
"output_rgb_array_name": "Feature Ids (Color)",
"selected_data_array_path": "DataContainer/CellData/FeatureIds",
"input_data_array_path": "DataContainer/CellData/FeatureIds",
"selected_preset": "hsv",
"use_mask": false
},
Expand All @@ -243,7 +243,7 @@
},
{
"args": {
"array_thresholds": {
"array_thresholds_object": {
"inverted": false,
"thresholds": [
{
Expand All @@ -258,7 +258,7 @@
"type": "collection",
"union": 0
},
"created_data_path": "Mask Inverse"
"output_data_array_name": "Mask Inverse"
},
"comments": "",
"filter": {
Expand Down Expand Up @@ -287,7 +287,7 @@
"args": {
"file_name": "Data/Output/Examples/Combo-EBSD-osc_r0c0._feature_ids.png",
"image_array_path": "DataContainer/CellData/Feature Ids (Color)",
"image_geom_path": "DataContainer",
"input_image_geometry_path": "DataContainer",
"index_offset": 0,
"plane": 0
},
Expand All @@ -314,9 +314,9 @@
},
{
"args": {
"avg_euler_angles_array_path": "AvgEulerAngles",
"avg_quats_array_path": "AvgQuats",
"cell_feature_attribute_matrix": "DataContainer/CellFeatureData",
"avg_euler_angles_array_name": "AvgEulerAngles",
"avg_quats_array_name": "AvgQuats",
"cell_feature_attribute_matrix_path": "DataContainer/CellFeatureData",
"cell_feature_ids_array_path": "DataContainer/CellData/FeatureIds",
"cell_phases_array_path": "DataContainer/CellData/Phases",
"cell_quats_array_path": "DataContainer/CellData/Quats",
Expand All @@ -331,16 +331,16 @@
},
{
"args": {
"boundary_cells": "BoundaryCells",
"cell_feature_arrays": "DataContainer/CellFeatureData",
"feature_ids": "DataContainer/CellData/FeatureIds",
"image_geometry": "DataContainer",
"neighbor_list": "NeighborList",
"number_of_neighbors": "NumNeighbors",
"shared_surface_area_list": "SharedSurfaceAreaList",
"boundary_cells_name": "BoundaryCells",
"cell_feature_array_path": "DataContainer/CellFeatureData",
"feature_ids_path": "DataContainer/CellData/FeatureIds",
"input_image_geometry_path": "DataContainer",
"neighbor_list_name": "NeighborList",
"number_of_neighbors_name": "NumNeighbors",
"shared_surface_area_list_name": "SharedSurfaceAreaList",
"store_boundary_cells": false,
"store_surface_features": false,
"surface_features": "SurfaceFeatures"
"surface_features_name": "SurfaceFeatures"
},
"comments": "",
"filter": {
Expand Down
40 changes: 20 additions & 20 deletions pipelines/PorosityAnalysis.d3dpipeline
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"args": {
"cell_attribute_matrix_name": "Optical Data",
"image_data_array_name": "ImageData",
"image_geometry_path": "RoboMet.3D Image Stack",
"output_image_geometry_path": "RoboMet.3D Image Stack",
"image_transform_choice": 0,
"input_file_list_info": {
"input_file_list_object": {
"end_index": 174,
"file_extension": ".tif",
"file_prefix": "slice_",
Expand Down Expand Up @@ -40,7 +40,7 @@
},
{
"args": {
"array_thresholds": {
"array_thresholds_object": {
"inverted": false,
"thresholds": [
{
Expand All @@ -55,7 +55,7 @@
"type": "collection",
"union": 0
},
"created_data_path": "Mask"
"output_data_array_name": "Mask"
},
"comments": "",
"filter": {
Expand All @@ -66,10 +66,10 @@
},
{
"args": {
"active_array_path": "Active",
"cell_feature_group_path": "Pore Data",
"active_array_name": "Active",
"cell_feature_group_name": "Pore Data",
"feature_ids_path": "FeatureIds",
"grid_geometry_path": "RoboMet.3D Image Stack",
"input_image_geometry_path": "RoboMet.3D Image Stack",
"input_array_path": "RoboMet.3D Image Stack/Optical Data/ImageData",
"mask_path": "RoboMet.3D Image Stack/Optical Data/Mask",
"randomize_features": true,
Expand All @@ -85,13 +85,13 @@
},
{
"args": {
"equivalent_diameters_path": "EquivalentDiameters",
"feature_attribute_matrix": "RoboMet.3D Image Stack/Pore Data",
"equivalent_diameters_name": "EquivalentDiameters",
"feature_attribute_matrix_path": "RoboMet.3D Image Stack/Pore Data",
"feature_ids_path": "RoboMet.3D Image Stack/Optical Data/FeatureIds",
"geometry_path": "RoboMet.3D Image Stack",
"num_elements_path": "NumElements",
"input_image_geometry_path": "RoboMet.3D Image Stack",
"num_elements_name": "NumElements",
"save_element_sizes": false,
"volumes_path": "Volumes"
"volumes_name": "Volumes"
},
"comments": "",
"filter": {
Expand All @@ -104,7 +104,7 @@
"args": {
"created_array_suffix": "",
"feature_ids_path": "RoboMet.3D Image Stack/Optical Data/FeatureIds",
"selected_feature_array_path": ["RoboMet.3D Image Stack/Pore Data/EquivalentDiameters"]
"selected_feature_array_paths": ["RoboMet.3D Image Stack/Pore Data/EquivalentDiameters"]
},
"comments": "",
"filter": {
Expand All @@ -115,12 +115,12 @@
},
{
"args": {
"advanced_options": false,
"set_tuple_dimensions": false,
"component_count": 1,
"data_format": "",
"initialization_value": "1",
"initialization_value_str": "1",
"numeric_type": 4,
"output_data_array": "RoboMet.3D Image Stack/Optical Data/Phases",
"output_array_path": "RoboMet.3D Image Stack/Optical Data/Phases",
"tuple_dimensions": [
[
0.0
Expand Down Expand Up @@ -165,10 +165,10 @@
},
{
"args": {
"centroids_array_path": "Centroids",
"feature_attribute_matrix": "RoboMet.3D Image Stack/Pore Data",
"centroids_array_name": "Centroids",
"feature_attribute_matrix_path": "RoboMet.3D Image Stack/Pore Data",
"feature_ids_path": "RoboMet.3D Image Stack/Optical Data/FeatureIds",
"selected_image_geometry": "RoboMet.3D Image Stack"
"input_image_geometry_path": "RoboMet.3D Image Stack"
},
"comments": "",
"filter": {
Expand Down Expand Up @@ -231,7 +231,7 @@
"rdf_array_name": "RDF",
"remove_biased_features": false,
"seed_value": 5489,
"selected_image_geometry": "RoboMet.3D Image Stack",
"input_image_geometry_path": "RoboMet.3D Image Stack",
"set_random_seed": false
},
"comments": "",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"args": {
"cell_attribute_matrix_name": "Cell Data",
"image_data_array_name": "ImageData",
"image_geometry_path": "ImageDataContainer",
"output_image_geometry_path": "ImageDataContainer",
"image_transform_choice": 0,
"input_file_list_info": {
"input_file_list_object": {
"end_index": 174,
"file_extension": ".tif",
"file_prefix": "slice_",
Expand Down Expand Up @@ -40,7 +40,7 @@
},
{
"args": {
"array_thresholds": {
"array_thresholds_object": {
"inverted": false,
"thresholds": [
{
Expand All @@ -55,7 +55,7 @@
"type": "collection",
"union": 0
},
"created_data_path": "Mask"
"output_data_array_name": "Mask"
},
"comments": "",
"filter": {
Expand All @@ -66,10 +66,10 @@
},
{
"args": {
"active_array_path": "Active",
"cell_feature_group_path": "CellFeatureData",
"feature_ids_path": "FeatureIds",
"grid_geometry_path": "ImageDataContainer",
"active_array_name": "Active",
"cell_feature_group_name": "CellFeatureData",
"feature_ids_name": "FeatureIds",
"input_image_geometry_path": "ImageDataContainer",
"input_array_path": "ImageDataContainer/Cell Data/ImageData",
"mask_path": "ImageDataContainer/Cell Data/Mask",
"randomize_features": true,
Expand All @@ -85,13 +85,13 @@
},
{
"args": {
"equivalent_diameters_path": "EquivalentDiameters",
"feature_attribute_matrix": "ImageDataContainer/CellFeatureData",
"equivalent_diameters_name": "EquivalentDiameters",
"feature_attribute_matrix_path": "ImageDataContainer/CellFeatureData",
"feature_ids_path": "ImageDataContainer/Cell Data/FeatureIds",
"geometry_path": "ImageDataContainer",
"num_elements_path": "NumElements",
"input_image_geometry_path": "ImageDataContainer",
"num_elements_name": "NumElements",
"save_element_sizes": false,
"volumes_path": "Volumes"
"volumes_name": "Volumes"
},
"comments": "",
"filter": {
Expand All @@ -104,7 +104,7 @@
"args": {
"created_array_suffix": "",
"feature_ids_path": "ImageDataContainer/Cell Data/FeatureIds",
"selected_feature_array_path": ["ImageDataContainer/CellFeatureData/EquivalentDiameters"]
"selected_feature_array_paths": ["ImageDataContainer/CellFeatureData/EquivalentDiameters"]
},
"comments": "",
"filter": {
Expand All @@ -115,12 +115,12 @@
},
{
"args": {
"advanced_options": false,
"set_tuple_dimensions": false,
"component_count": 1,
"data_format": "",
"initialization_value": "1",
"initialization_value_str": "1",
"numeric_type": 4,
"output_data_array": "ImageDataContainer/Cell Data/Phases",
"output_array_path": "ImageDataContainer/Cell Data/Phases",
"tuple_dimensions": [
[
164.0,
Expand Down Expand Up @@ -167,10 +167,10 @@
},
{
"args": {
"centroids_array_path": "Centroids",
"feature_attribute_matrix": "ImageDataContainer/CellFeatureData",
"centroids_array_name": "Centroids",
"feature_attribute_matrix_path": "ImageDataContainer/CellFeatureData",
"feature_ids_path": "ImageDataContainer/Cell Data/FeatureIds",
"selected_image_geometry": "ImageDataContainer"
"input_image_geometry_path": "ImageDataContainer"
},
"comments": "",
"filter": {
Expand Down
Loading
Loading