ENH: Filter Parameter for COPY/MOVE options are consistent #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyoungbq
approved these changes
May 30, 2024
imikejackson
force-pushed
the
topic/copy_data_objects_tweaks
branch
from
7d6de88 to
674f319
Compare
imikejackson
changed the title
This makes them a bit more obvious to the user. Signed-off-by: Michael Jackson <[email protected]>
- There was a miss-mash of "Copy", "Move" and "Move", "Copy" - Only Copy and Move was exposed to the Python bindings Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/copy_data_objects_tweaks
branch
from
674f319 to
154ed61
Compare
imikejackson
added a commit
to imikejackson/simplnx
that referenced
this pull request
Oct 20, 2024
…zSoftware#983) Created Enums that should be used for Array handling in these kinds of filters Update the python bindings to also expose the enums to the python side. Signed-off-by: Michael Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them a bit more obvious to the user.