Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215 make oracledbhelperget sqlalchemy connection string use oracle+oracledb instead of oracle #217

Conversation

leorudczenko
Copy link
Collaborator

Summary

This merge request applies the change specified in #215, and makes an appropriate adjustment to the tests.

Copy link
Collaborator

@volcan01010 volcan01010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not much to see!

@volcan01010 volcan01010 merged commit e466256 into main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make OracleDbHelper.get_sqlalchemy_connection_string use oracle+oracledb instead of oracle
2 participants