Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Remove secondary call to segmentation generation #114

Conversation

NicerNewerCar
Copy link
Contributor

No description provided.

@NicerNewerCar NicerNewerCar requested a review from jcfr July 24, 2024 17:35
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the commit message and pull request to reference when the call was first introduced and why it makes sense remove it (e.g which problem is this fixing), this is good for integration 🚀

Regression initially introduced in e036c22. The secondary call is removed
here to prevent multiple calls to the automatic segmentation pipeline.
@NicerNewerCar NicerNewerCar force-pushed the remove-extra-call-to-autosegment branch from 8da8625 to aec6381 Compare July 31, 2024 19:29
@NicerNewerCar NicerNewerCar merged commit f53f33b into BrownBiomechanics:main Jul 31, 2024
2 checks passed
@NicerNewerCar NicerNewerCar deleted the remove-extra-call-to-autosegment branch July 31, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants