-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roi from model bounds #152
base: main
Are you sure you want to change the base?
Conversation
@sbelsk You can take this and help iterate on it or make another from scratch TO DO:
and the generated roi to generate subvolumes |
Thanks @amymmorton for creating this PR along side issue #151 describing the overall workflow and providing reference to datasets 🙏 |
@sbelsk can you help me fix my failing precommit, Commit messages please? :( |
pre-commit checkThe pre-commit failures have been addressed. commit message checkThe commit message check is failing because some commits start with Addressing this could be done by using |
From Extension wizard
Currently broken ui elements module
Tutorial mcode diff example
Content stl file read
Remove mcode examples
TO DO: assign to roi
TO DO: Use model bounds and input Volume to generate subvolume
Loads Models form folder and iteratively generates each roi
Since the base class associated with scripted module class `ScriptedLoadableModuleTest` is `unittest.TestCase`, using function like assertEqual is legitimate and should not be replaced with `assert`. References: * https://docs.python.org/3/library/unittest.html#unittest.TestCase * https://docs.astral.sh/ruff/rules/#flake8-pytest-style-pt
* Remove end of line spaces * Reorder imports * Prefer explicit imports instead of "*" * Add missing spaces * Add ARG002 linting exceptions for unused "modelBounds" parameters Most of the fixes where either automatically fixed or identified running `pre-commit run -a`.
613726f
to
cdfcd23
Compare
Cleanup commented out irrelevant lines and migrate functionality into logic class
Also corrected signal and slot that link inputVolume ui to MRML scene.
A start to the subvolume 3d registration testing, implements the roi generation from model bounds
TO DO:
iterate on all Models | load from file