-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install cleanup #326
base: master
Are you sure you want to change the base?
Install cleanup #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@downiec please make sure we do not need space before =2 and also we need to tag vcs and vcs to some stable versions.,
Can anyone give a quick explanation of the meta.yaml.in and meta.yaml.official? These files cant be used by conda directly, so are they being manipulated by Travis or something? @James-Crean @doutriaux1 |
@sterlingbaldwin official is the recipe used to produce the official/stable release, just so we easily remember what we used. The ".in" one is the one we used in relation with http://github.com/cdat/conda-recipes to generate the meta.yaml for nightly using correct branch, etc... Also has capabilites for repos with "features" (only vtk-cdat at this point) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the conda create line needs to install the vcdat package.
scripts/setup.sh
Outdated
@@ -47,7 +47,7 @@ if [[ $current_dir == */vcdat* ]]; then | |||
conda env remove -y -n ${CONDA_ENV} | |||
|
|||
# Create a new one | |||
conda create -y -n ${CONDA_ENV} -c cdat/label/nightly -c conda-forge -c cdat --file $current_dir/backend/requirements.txt | |||
conda create -y -n ${CONDA_ENV} -c cdat/label/nightly -c conda-forge -c cdat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should read
conda create -y -n ${CONDA_ENV} -c cdat/label/nightly -c conda-forge -c cdat vcdat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think you're right. I went ahead and updated that. Thanks!
Updated meta.yaml files to make sure python2 is used in conda environment to avoid run from having python 3. Added Sterling's handy conda_build.sh. Other minor changes and cleanup.