Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional cdefs #102

Closed
wants to merge 2 commits into from
Closed

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Feb 28, 2024

This patch add structure of lysp_node_grp and API to add or remove strings from context dictionary

@steweg steweg mentioned this pull request Feb 28, 2024
Copy link
Collaborator

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

please add a basic Python API to wrap these new cdefs. Along with some unit tests to show how you intent on using them.

Thanks!

@steweg steweg force-pushed the feature/additional_cdefs branch 8 times, most recently from 23d8724 to 389f464 Compare March 3, 2024 22:10
@steweg steweg requested a review from rjarry March 4, 2024 16:07
@rjarry
Copy link
Collaborator

rjarry commented Mar 26, 2024

Hi,

libyang-python only supports the master branch of C libyang (currently 2.x).

The lydevel check is only meant for informative purposes.

libyang-python/tox.ini

Lines 18 to 20 in f09ed11

[testenv:lydevel]
setenv =
LIBYANG_BRANCH=devel

If it fails (currently it should fail because libyang 3.x is under development) it is not a problem.

Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require?

Thank you.

@steweg steweg force-pushed the feature/additional_cdefs branch from 389f464 to 87104cb Compare March 30, 2024 09:59
@steweg
Copy link
Contributor Author

steweg commented Mar 30, 2024

Hi,

libyang-python only supports the master branch of C libyang (currently 2.x).

The lydevel check is only meant for informative purposes.

libyang-python/tox.ini

Lines 18 to 20 in f09ed11

[testenv:lydevel]
setenv =
LIBYANG_BRANCH=devel

If it fails (currently it should fail because libyang 3.x is under development) it is not a problem.

Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require?

Thank you.

Done

@steweg steweg force-pushed the feature/additional_cdefs branch 3 times, most recently from 5b2806d to 99a5dcd Compare April 6, 2024 10:29
@steweg steweg mentioned this pull request Apr 12, 2024
steweg added 2 commits April 29, 2024 08:37
This patch introduces PNode alternative to SNode, which allows to
travers parsed module tree including groupings, uses and other special
nodes

Signed-off-by: Stefan Gula <[email protected]>
This patch adds add_to_dict and remove_from_dict API, which allows to create internal
string reference within the context

Signed-off-by: Stefan Gula <[email protected]>
@steweg steweg force-pushed the feature/additional_cdefs branch from 99a5dcd to c09c84d Compare April 29, 2024 06:38
@steweg steweg requested a review from samuel-gauthier May 9, 2024 10:48
samuel-gauthier added a commit that referenced this pull request Aug 2, 2024
Those functions can return None, fix their expected type.

Closes: #102
Signed-off-by: Stefan Gula <[email protected]>
Signed-off-by: Samuel Gauthier <[email protected]>
samuel-gauthier added a commit that referenced this pull request Aug 2, 2024
The cdata type that is actually lysp_import, fix it.

Closes: #102
Signed-off-by: Stefan Gula <[email protected]>
Signed-off-by: Samuel Gauthier <[email protected]>
samuel-gauthier added a commit that referenced this pull request Aug 2, 2024
Add a new function to go through a libyang list, equivalent to
LY_LIST_FOR.

Closes: #102
Signed-off-by: Stefan Gula <[email protected]>
Signed-off-by: Samuel Gauthier <[email protected]>
samuel-gauthier pushed a commit that referenced this pull request Aug 2, 2024
This patch introduces PNode alternative to SNode, which allows to
traverse parsed module tree including groupings, uses and other special
nodes.

Closes: #102
Signed-off-by: Stefan Gula <[email protected]>
Signed-off-by: Samuel Gauthier <[email protected]>
samuel-gauthier pushed a commit that referenced this pull request Aug 2, 2024
This patch adds add_to_dict and remove_from_dict API, which allows to
create internal string reference within the context.

Closes: #102
Signed-off-by: Stefan Gula <[email protected]>
@samuel-gauthier
Copy link
Collaborator

Pushed with a few changes and fixes. Very sorry for the delays.

@steweg steweg deleted the feature/additional_cdefs branch August 3, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants