Reworked musts to use common function #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steweg
force-pushed
the
feature/must_refactor
branch
3 times, most recently
from
b04f66c to
deb23c8
Compare
This patches replaces separate implementations of must_conditions with one common implementation. It also introduces new class Must and musts function to get details of all musts including pattern and error-message
steweg
force-pushed
the
feature/must_refactor
branch
from
deb23c8 to
64906f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches replaces separate implementstions of must_conditions with one common implementation. It also introduces must_conditions_details function to get details of all musts including pattern and error-message