Extending pattern options #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steweg
force-pushed
the
feature/extended_patterns
branch
from
df6888e to
65aa2dc
Compare
steweg
force-pushed
the
feature/extended_patterns
branch
2 times, most recently
from
1f5a211 to
a70d349
Compare
This patch introduces patterns_details and all_patterns_details functions, which allows user to get also associated error-message
steweg
force-pushed
the
feature/extended_patterns
branch
from
a70d349 to
5c97853
Compare
samuel-gauthier
added a commit
that referenced
this pull request
Jan 29, 2024
Now that we have the Pattern class, use it for the patterns() method. Fixes: #92 Signed-off-by: Samuel Gauthier <[email protected]>
|
Pushed with minor rewording. I added a commit to make use of the Pattern class for the patterns() method. |
|
I thought about the same thing, but it could potentially create backward
incompatibility as the original code was based on "parsed", the new one is
based on "compiled", which I am not 100% sure if it would differ or not.
Hopefully not.
po 29. 1. 2024 o 13:37 samuel-gauthier ***@***.***>
napísal(a):
… Pushed with minor rewording. I added a commit to make use of the Pattern
class for the patterns() method.
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYLKDTBFUTF6XDDDJSLFPTYQ6JZTAVCNFSM6AAAAABCL55W5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGYYTCNRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Stefan Gula
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces patterns_details and all_patterns_details functions, which allows user to get also associated error-message