Clipboard Improvements #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things that need to get worked on:
|
|
@bjoernh2000 let me know if you can work on this? |
Comment on lines
+115
to
118
| let selection = reference.view.getSelectedFeatures(); | ||
| if (selectedFeatures.length > 0) { | ||
| reference.pasteboard[0] = selectedFeatures[0]; | ||
| } |
There was a problem hiding this comment.
It seems like the cut system also got modified during the variable change but its not using the latest selection system
There was a problem hiding this comment.
Ok I can change that to also use the recent selection system
Comment on lines
+132
to
+141
|
|
||
| // if (pasteboardFeatures.length == 1) { // 1 feature | ||
| // reference.updateDefaultsFromFeature(pasteboardFeatures[0]); | ||
| // reference.activateTool(pasteboardFeatures[0].getType()); | ||
|
|
||
| // } else if (pasteboardFeatures.length > 1) { // multiple features | ||
| // console.log("multiple features detected") | ||
| // reference.updateDefaultsFromFeatures(pasteboardFeatures); | ||
| // reference.activateTools(pasteboardFeatures); | ||
| // } |
There was a problem hiding this comment.
Delete these if you are not planning to use them anymore
rkrishnasanka
requested changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Clipboard to allow multiple clippings.
Further fixes needed: