Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kayukawa/description request #160

Merged
merged 15 commits into from
Mar 6, 2025
Merged

Kayukawa/description request #160

merged 15 commits into from
Mar 6, 2025
+81 −24

Conversation

SeitaKayukawa
Copy link
Contributor

  • ignore description event for 10 seconds after previous description event
  • set description speech priority as MODERATE (value: 25)

SeitaKayukawa and others added 15 commits March 4, 2025 15:35
@SeitaKayukawa
[WIP, #757] Prevent new description requests while a previous request…
3a63e85 
… is still processing.

Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
[#757] thread-safe handling of simultaneous description events
bd61562 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
set description speech priority as MODERATE
9f967d6 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
set MODERATE priority value as 25
f72d7c4 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
Prevent blocking on repeated events by using acquire(blocking=False) …
ff5f41a 
…with try-finally for safe lock release.

Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
set speech timeout
2e71887 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
clean code
cb42fef 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
set default timeout value as 0
996eece 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
Merge remote-tracking branch 'origin/daisukes/public-image-desc-serve…
74c5c31 
…r' into kayukawa/description_request
@SeitaKayukawa
revert 2e71887 cb42fef 996eece
0667238 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
Merge branch 'main' into kayukawa/description_request
9ea4ed9
@SeitaKayukawa
call processing_lock.release()
ccd0ef0 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
ignore description event for 10 seconds after previous event
3205a85 
Signed-off-by: Seita Kayukawa <[email protected]>
@SeitaKayukawa
Allow the description event immediately when TTS is paused
a017943 
Signed-off-by: Seita Kayukawa <[email protected]>
@daisukes
Merge remote-tracking branch 'origin/main' into kayukawa/description_…
84e9dd1 
…request
@daisukes daisukes merged commit 7f42b86 into main Mar 6, 2025
2 checks passed
@daisukes daisukes deleted the kayukawa/description_request branch March 6, 2025 14:13
@SeitaKayukawa SeitaKayukawa restored the kayukawa/description_request branch March 7, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daisukes daisukes daisukes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeitaKayukawa @daisukes