New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APD F120 packet modification #138

Merged

loki077 merged 7 commits into CxPilot from feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean

Jun 4, 2024

Collaborator

robertlong13 commented May 23, 2024 •

edited

Loading

Add support for uavcan.equipment.esc.StatusExtended, and also for APD's new extended version of BLHeli tememetry.

robertlong13 assigned Pradeep-Carbonix

Pradeep-Carbonix force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch from 5774d3f to a4aa7bb Compare

May 24, 2024 06:20

robertlong13 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch 2 times, most recently from e5303d2 to 9c474a5 Compare

May 27, 2024 02:57

robertlong13 marked this pull request as ready for review

May 27, 2024 02:58

robertlong13 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch 3 times, most recently from 5cb9f2a to c2f18b7 Compare

May 27, 2024 04:18

robertlong13 requested a review from loki077

May 27, 2024 04:18

loki077 reviewed

View reviewed changes

libraries/AP_UAVCAN/AP_UAVCAN.cpp Outdated Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_ESC_Telem/AP_ESC_Telem.h Outdated Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_UAVCAN/AP_UAVCAN.h Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_UAVCAN/AP_UAVCAN.cpp Outdated Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_ESC_Telem/LogStructure.h Outdated Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_ESC_Telem/LogStructure.h Outdated Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_ESC_Telem/AP_ESC_Telem_Backend.h Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_BLHeli/AP_BLHeli.h Outdated Show resolved Hide resolved

loki077 reviewed

View reviewed changes

libraries/AP_BLHeli/AP_BLHeli.cpp Outdated Show resolved Hide resolved

loki077 requested changes

View reviewed changes

Contributor

loki077 left a comment

make all the suggested changes and will review again

loki077 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch from c2f18b7 to 7c07a46 Compare

May 28, 2024 00:34

loki077 requested a review from Pradeep-Carbonix

May 28, 2024 00:35

loki077 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch from 7c07a46 to 7064d6d Compare

May 28, 2024 00:43

Contributor

loki077 commented May 28, 2024

@robertlong13 you can review it.

loki077 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch from 7064d6d to 313c678 Compare

May 28, 2024 00:51

robertlong13 commented

View reviewed changes

Collaborator Author

robertlong13 left a comment

Your fixed look good to me. I'm technically primary author, so I can't submit an approve.

loki077 approved these changes

View reviewed changes

Contributor

loki077 left a comment

Code Review done. After final testing on thrust stand merge the code.

loki077 and others added 4 commits

May 27, 2024 19:55


          .gitmodule: update DSDL to carbonix fork

e59d86a

SW-187


          module: libcanard checkout Cx_dev branch

1c74533

added cherry pick of uavcan.esc.StatusExtended message

SW-187


          AP_ESC: add extended telemetry data fields and log message

4b50ab3

- additional data fields for ESC backends
- add extended telemetry log message
SW-187


          AP_UAVCAN: add handler for esc.StatusExtended

d3a78a1

SW-187


          AP_Periph: output esc.StatusExtended

93fbb10

SW-187

loki077 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch from 313c678 to 7da348d Compare

May 28, 2024 03:03

robertlong13 added 2 commits

May 29, 2024 19:50


          AP_BLHeli: add support for 13-byte ext. telemetry

eb8ecfd

SW-187


          CarbonixF405: fix ESC[15] bug

fb15ade

This fixes an issue where an errant ESC[15] would show up for 5 seconds
after boot that would contain NaN values. This is related to a bug that
was years ago in ArduPilot: ArduPilot/ardupilot#22308

Basically, different areas of the code had different values for
ESC_TELEM_MAX_ESCS based which other header files were included at that
time.

SW-187

robertlong13 force-pushed the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch from 7da348d to fb15ade Compare

May 30, 2024 00:58

loki077 merged commit 1f464b6 into CxPilot

62 checks passed

robertlong13 deleted the feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean branch

June 17, 2024 07:04

robertlong13 added a commit that referenced this pull request


          CarbonixF405: fix ESC[15] bug

354f5c7

I accidentally dropped this change when resolving a merge conflict while
rebasing #136 onto #138.

This fixes an issue where an errant ESC[15] would show up for 5 seconds
after boot that would contain NaN values. This is related to a bug that
was years ago in ArduPilot: ArduPilot/ardupilot#22308

Basically, different areas of the code had different values for
ESC_TELEM_MAX_ESCS based which other header files were included at that
time.

SW-244

robertlong13 mentioned this pull request

CarbonixF405: fix ESC[15] bug #153

Merged

robertlong13 added a commit that referenced this pull request


          CarbonixF405: fix ESC[15] bug

3f94583

I accidentally dropped this change when resolving a merge conflict while
rebasing #136 onto #138.

This fixes an issue where an errant ESC[15] would show up for 5 seconds
after boot that would contain NaN values. This is related to a bug that
was years ago in ArduPilot: ArduPilot/ardupilot#22308

Basically, different areas of the code had different values for
ESC_TELEM_MAX_ESCS based which other header files were included at that
time.

SW-244

robertlong13 added a commit that referenced this pull request


          CarbonixF405: fix ESC[15] bug

I accidentally dropped this change when resolving a merge conflict while
rebasing #136 onto #138.

This fixes an issue where an errant ESC[15] would show up for 5 seconds
after boot that would contain NaN values. This is related to a bug that
was years ago in ArduPilot: ArduPilot/ardupilot#22308

Basically, different areas of the code had different values for
ESC_TELEM_MAX_ESCS based which other header files were included at that
time.

SW-244

robertlong13 added a commit that referenced this pull request


          CarbonixF405: fix ESC[15] bug

9edba4b

I accidentally dropped this change when resolving a merge conflict while
rebasing #136 onto #138.

This fixes an issue where an errant ESC[15] would show up for 5 seconds
after boot that would contain NaN values. This is related to a bug that
was years ago in ArduPilot: ArduPilot/ardupilot#22308

Basically, different areas of the code had different values for
ESC_TELEM_MAX_ESCS based which other header files were included at that
time.

SW-244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet