APD F120 packet modification #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pradeep-Carbonix
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
from
5774d3f to
a4aa7bb
Compare
robertlong13
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
2 times, most recently
from
e5303d2 to
9c474a5
Compare
robertlong13
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
3 times, most recently
from
5cb9f2a to
c2f18b7
Compare
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
reviewed
May 27, 2024
loki077
requested changes
May 27, 2024
loki077
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
from
c2f18b7 to
7c07a46
Compare
loki077
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
from
7c07a46 to
7064d6d
Compare
|
@robertlong13 you can review it. |
loki077
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
from
7064d6d to
313c678
Compare
robertlong13
commented
May 28, 2024
loki077
approved these changes
May 28, 2024
added cherry pick of uavcan.esc.StatusExtended message SW-187
- additional data fields for ESC backends - add extended telemetry log message SW-187
loki077
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
from
313c678 to
7da348d
Compare
This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-187
robertlong13
force-pushed
the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
from
7da348d to
fb15ade
Compare
robertlong13
deleted the
feature/SW-187-firmware-to-handle-apd-f-120-packet-modification_clean
branch
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
robertlong13
added a commit
that referenced
this pull request
Jun 18, 2024
I accidentally dropped this change when resolving a merge conflict while rebasing #136 onto #138. This fixes an issue where an errant ESC[15] would show up for 5 seconds after boot that would contain NaN values. This is related to a bug that was years ago in ArduPilot: ArduPilot/ardupilot#22308 Basically, different areas of the code had different values for ESC_TELEM_MAX_ESCS based which other header files were included at that time. SW-244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for uavcan.equipment.esc.StatusExtended, and also for APD's new extended version of BLHeli tememetry.