hwdef fixups #215
Merged
hwdef fixups #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
force-pushed
the
feature/SW-409-hwdef-fixups
branch
from
b72ea09 to
9d4bbb7
Compare
For ADC_3, which optionally connects to CN7 pin 5, old versions of CxPilot used a hard-coded fit within the fuel monitor battery backend of 797.76 counts per volt. This scaling parameter is the correct way to adjust this. By default, AP scales assuming 3.3V, with a scaling of 4096 counts for 3.3V. I used the hard-coded scaling to calculate the 1.556 in this PR.
The existence of this feature freaks people out.
robertlong13
force-pushed
the
feature/SW-409-hwdef-fixups
branch
from
9d4bbb7 to
42bb522
Compare
robertlong13
force-pushed
the
feature/SW-409-hwdef-fixups
branch
from
42bb522 to
221acaf
Compare
Pradeep-Carbonix
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SW-409