Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbonix Custom Hardware Def #73

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2023

We need to test this PR.
Tests:
Need to look at if we have added all the features required for each board.
Need to check the default.parm
Need to check if LUA is build with it.
Need to add Hirth,QMC and Pre ARM check in default hwdef
Need to also test it on hardware
Need to see the Cube parameter modification as we have reduced alot of functionality and need to be sure we have not missed any functionality.

@robertlong13
Copy link
Collaborator

robertlong13 commented Nov 19, 2023

Wing CPN builds are failing:

Failed builds:
  configure: Ottano-LWing
  configure: Ottano-RWing
  configure: Volanti-LWing
  configure: Volanti-RWing
Error: Duplicate MAG: ['QMC5883P', 'I2C:0:0x2C']

Copy link
Contributor

@Jono453 Jono453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made comments regarding trim values and reverse params for Ottano and Volanti left/right tail and wings to keep it as production params across already built Volanti and Ottano

@ghost ghost force-pushed the feature/OV3-871-custom-hwdef-438 branch from f97ff57 to cb31fd8 Compare November 20, 2023 01:59
@loki077 loki077 force-pushed the feature/OV3-871-custom-hwdef-438 branch 2 times, most recently from b984678 to b6993ea Compare November 22, 2023 22:28
@loki077
Copy link
Contributor

loki077 commented Nov 22, 2023

image
hwdef according to discussion

@Jono453
Copy link
Contributor

Jono453 commented Nov 22, 2023

Just reminder to update the can srv bit mask for cube in parameters later on

@loki077 loki077 force-pushed the feature/OV3-871-custom-hwdef-438 branch from e0fbd93 to b28dc75 Compare November 22, 2023 23:49
@loki077 loki077 force-pushed the feature/OV3-871-custom-hwdef-438 branch from b28dc75 to c96e747 Compare November 23, 2023 00:13
@loki077 loki077 force-pushed the feature/OV3-871-custom-hwdef-438 branch from c96e747 to 8252c30 Compare November 23, 2023 00:54
loki077 and others added 10 commits November 27, 2023 15:38
Create a custom board based out of CubeOrange
Add default parm , hardware def and lua script
kept only default #defines
Added 9 different boards which are based on CarbonixF405 and have default. parm
Added 9 different boards which are based on CarbonixF405 and have default. parm
Not part of Ardupilot 4.3.8 Firmware test suite.
@loki077 loki077 force-pushed the feature/OV3-871-custom-hwdef-438 branch from 235cbb7 to 68ff23f Compare November 27, 2023 23:54
@Pradeep-Carbonix Pradeep-Carbonix merged commit 468b1e6 into CxPilot Nov 28, 2023
61 checks passed
@robertlong13 robertlong13 deleted the feature/OV3-871-custom-hwdef-438 branch June 17, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants