Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-worked on #Add pylint workflow and fix all issues" #269

Merged
merged 28 commits into from
Nov 1, 2024
Merged

re-worked on #Add pylint workflow and fix all issues" #269

merged 28 commits into from
Nov 1, 2024

Conversation

sigmadawg
Copy link
Contributor

addresses #262

@djeck1432 djeck1432 self-requested a review October 31, 2024 08:56
@djeck1432 djeck1432 linked an issue Oct 31, 2024 that may be closed by this pull request
Add pylint workflow and fix all issues #262
Closed
djeck1432
djeck1432 requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work this way with some text in docstring, it should contain description of the class/file/method/function not just some random text

@sigmadawg
Copy link
Contributor Author

@djeck1432 Could you kindly check if its alright now?

@djeck1432 djeck1432 marked this pull request as ready for review October 31, 2024 20:03
djeck1432
djeck1432 requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, resolve merge conflict and revert removed field

@sigmadawg
Copy link
Contributor Author

KIndly check

djeck1432
djeck1432 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe biggest PR ever 116 files
looks good to me

@djeck1432
Copy link
Collaborator

@sigmadawg Please fix one test case and I will merge it

@sigmadawg
Copy link
Contributor Author

Kindly check
image

@sigmadawg
Copy link
Contributor Author

is this okay?

@djeck1432
Copy link
Collaborator

@sigmadawg run pipeline, will see soon

@sigmadawg
Copy link
Contributor Author

I ran the workflow, attached the pictures above

@djeck1432
Copy link
Collaborator

@sigmadawg Pylint not passed
https://github.com/CarmineOptions/derisk-research/actions/runs/11626963851/job/32379739187?pr=269

@djeck1432
Copy link
Collaborator

did you sync with master? because I have another result
Screenshot 2024-11-01 at 10 14 12

@sigmadawg
Copy link
Contributor Author

Kindly check @djeck1432

@djeck1432 djeck1432 merged commit 93148b5 into CarmineOptions:master Nov 1, 2024
2 checks passed
@djeck1432
Copy link
Collaborator

@sigmadawg merged, passed

@sigmadawg
Copy link
Contributor Author

thankss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

Assignees

@sigmadawg sigmadawg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pylint workflow and fix all issues
2 participants
@sigmadawg @djeck1432