re-worked on #Add pylint workflow and fix all issues"

.github/workflows/pylint.yml

@@ -0,0 +1,33 @@
+name: Pylint Check
+
+on:
+  push:
+    paths:
+      - 'apps/data_handler/**/*.py'
+  pull_request:
+    paths:
+      - 'apps/data_handler/**/*.py'
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: apps
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Set up Python 3.11
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.11'
+
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        pip install pylint
+
+    - name: Run Pylint
+      run: |
+        python -m pylint $(git ls-files './apps/data_handler/*.py') --disable=all --enable=C0114,C0115,C0116,C0301 --rcfile=./.pylintrc

.pylintrc

@@ -0,0 +1,5 @@
+[FORMAT]
+max-line-length=150
+
+[MESSAGES CONTROL]
+disable=C0301,C0114,C0115,C0116

.style.yapf

@@ -0,0 +1,6 @@
+[style]
+based_on_style = pep8
+column_limit = 100
+split_before_logical_operator = true
+dedent_closing_brackets = true
+split_before_first_argument = true

apps/data_handler/__init__.py

@@ -1 +1,2 @@
+"""Module docstring placeholder."""
 

apps/data_handler/celery_app/__init__.py

@@ -0,0 +1,2 @@
+"""Module docstring placeholder."""
+

apps/data_handler/celery_app/celery_conf.py

@@ -1,3 +1,14 @@
+"""Module docstring placeholder."""
+
+# run_loan_states_computation_for_hashtack_v0,; 
+# run_loan_states_computation_for_hashtack_v1,; run_loan_states_computation_for_nostra_alpha,; 
+# run_loan_states_computation_for_nostra_mainnet,; run_loan_states_computation_for_zklend,; 
+# run_liquidable_debt_computation_for_nostra_alpha,; run_liquidable_debt_computation_for_nostra_mainnet,; 
+# run_liquidable_debt_computation_for_hashstack_v0,; run_liquidable_debt_computation_for_hashstack_v1,; uniswap_v2_order_book,
+from data_handler.celery_app.tasks import (
+    run_liquidable_debt_computation_for_zklend,
+)
+from data_handler.celery_app.order_books_tasks import ekubo_order_book
 import os
 
 from celery import Celery
@@ -10,10 +21,8 @@
 REDIS_HOST = os.environ.get("REDIS_HOST", "")
 REDIS_PORT = os.environ.get("REDIS_PORT", 6379)
 
-
 ORDER_BOOK_TIME_INTERVAL = int(os.environ.get("ORDER_BOOK_TIME_INTERVAL", 5))
 
-
 app = Celery(
     main="DataHandler",
     broker=f"redis://{REDIS_HOST}:{REDIS_PORT}/0",
@@ -57,9 +66,4 @@
     },
 }
 
-from data_handler.celery_app.order_books_tasks import ekubo_order_book
-from data_handler.celery_app.tasks import (
-    run_liquidable_debt_computation_for_zklend,
-)  # run_loan_states_computation_for_hashtack_v0,; run_loan_states_computation_for_hashtack_v1,; run_loan_states_computation_for_nostra_alpha,; run_loan_states_computation_for_nostra_mainnet,; run_loan_states_computation_for_zklend,; run_liquidable_debt_computation_for_nostra_alpha,; run_liquidable_debt_computation_for_nostra_mainnet,; run_liquidable_debt_computation_for_hashstack_v0,; run_liquidable_debt_computation_for_hashstack_v1,; uniswap_v2_order_book,
-
 app.autodiscover_tasks(["celery_app.tasks", "celery_app.order_books_tasks"])

apps/data_handler/celery_app/order_books_tasks.py

@@ -1,3 +1,5 @@
+"""Module docstring placeholder."""
+
 import logging
 
 from data_handler.celery_app.celery_conf import app
@@ -19,27 +21,20 @@ def ekubo_order_book():
     """
     pool_states = EkuboAPIConnector().get_pools()
     filtered_pool_states = [
-        pool_state
-        for pool_state in pool_states
-        if isinstance(pool_state, dict)
-        and pool_state["token0"] in TOKEN_MAPPING
-        and pool_state["token1"] in TOKEN_MAPPING
+        pool_state for pool_state in pool_states if isinstance(pool_state, dict)
+        and pool_state["token0"] in TOKEN_MAPPING and pool_state["token1"] in TOKEN_MAPPING
     ]
     for pool_state in filtered_pool_states:
         token_a = pool_state["token0"]
         token_b = pool_state["token1"]
-        logging.getLogger().info(
-            f"Fetching data for token pair: {token_a} and {token_b}"
-        )
+        logging.getLogger().info(f"Fetching data for token pair: {token_a} and {token_b}")
         try:
             order_book = EkuboOrderBook(token_a, token_b)
             order_book.fetch_price_and_liquidity()
             serialized_data = order_book.serialize()
             connector.write_to_db(OrderBookModel(**serialized_data.model_dump()))
         except Exception as exc:
-            logger.info(
-                f"With token pair: {token_a} and {token_b} something happened: {exc}"
-            )
+            logger.info(f"With token pair: {token_a} and {token_b} something happened: {exc}")
             continue
 
 

apps/data_handler/celery_app/tasks.py

@@ -1,3 +1,5 @@
+"""Module docstring placeholder."""
+
 import logging
 from time import monotonic
 
@@ -13,7 +15,9 @@
 # from data_handler.handlers.loan_states.hashtack_v0.run import HashtackV0StateComputation
 # from data_handler.handlers.loan_states.hashtack_v1.run import HashtackV1StateComputation
 # from data_handler.handlers.loan_states.zklend.run import ZkLendLoanStateComputation
-from data_handler.handlers.loan_states.nostra_alpha.run import NostraAlphaStateComputation
+from data_handler.handlers.loan_states.nostra_alpha.run import (
+    NostraAlphaStateComputation,
+)
 from data_handler.handlers.order_books.constants import TOKEN_MAPPING
 from data_handler.handlers.order_books.ekubo.api_connector import EkuboAPIConnector
 from data_handler.handlers.order_books.uniswap_v2.main import UniswapV2OrderBook
@@ -25,7 +29,6 @@
 
 connector = DBConnector()
 
-
 # @app.task(name="run_loan_states_computation_for_hashtack_v0")
 # def run_loan_states_computation_for_hashtack_v0():
 #     start = monotonic()
@@ -40,7 +43,6 @@
 #         monotonic() - start,
 #     )
 
-
 # @app.task(name="run_loan_states_computation_for_hashtack_v1")
 # def run_loan_states_computation_for_hashtack_v1():
 #     start = monotonic()
@@ -55,7 +57,6 @@
 #         monotonic() - start,
 #     )
 
-
 # @app.task(name="run_loan_states_computation_for_zklend")
 # def run_loan_states_computation_for_zklend():
 #     start = monotonic()
@@ -73,6 +74,7 @@
 
 @app.task(name="run_loan_states_computation_for_nostra_alpha")
 def run_loan_states_computation_for_nostra_alpha():
+    """fn docstring"""
     start = monotonic()
     logging.basicConfig(level=logging.INFO)
 
@@ -124,34 +126,39 @@ def uniswap_v2_order_book():
 
 @app.task(name="run_liquidable_debt_computation_for_zklend")
 def run_liquidable_debt_computation_for_zklend():
+    """fn docstring"""
     logging.info("Starting zkLend liquidable debt computation")
     zklend.run()
     logging.info("zkLend liquidable debt computation finished")
 
 
 @app.task(name="run_liquidable_debt_computation_for_nostra_alpha")
 def run_liquidable_debt_computation_for_nostra_alpha():
+    """fn docstring"""
     logging.info("Starting nostra alpha liquidable debt computation")
     nostra_alpha.run()
     logging.info("Nostra alpha liquidable debt computation finished")
 
 
 @app.task(name="run_liquidable_debt_computation_for_hashstack_v0")
 def run_liquidable_debt_computation_for_hashstack_v0():
+    """fn docstring"""
     logging.info("Starting hashstack v0 liquidable debt computation")
     hashstack_v0.run()
     logging.info("Hashstack v0 liquidable debt computation finished")
 
 
 @app.task(name="run_liquidable_debt_computation_for_nostra_mainnet")
 def run_liquidable_debt_computation_for_nostra_mainnet():
+    """fn docstring"""
     logging.info("Starting nostra mainnet liquidable debt computation")
     nostra_mainnet.run()
     logging.info("Nostra mainnet liquidable debt computation finished")
 
 
 @app.task(name="run_liquidable_debt_computation_for_hashstack_v1")
 def run_liquidable_debt_computation_for_hashstack_v1():
+    """fn docstring"""
     logging.info("Starting hashstack v1 liquidable debt computation")
     hashstack_v1.run()
     logging.info("Hashstack v1 liquidable debt computation finished")

apps/data_handler/db/__init__.py

@@ -1 +1,3 @@
+"""Module docstring placeholder."""
+
 from data_handler.db.database import SQLALCHEMY_DATABASE_URL, Base