Fix issues with packager

[nnyyxxxx]

Merge with #443 #440 #454

Type of Change

• Bug fix
• Refactoring

Description

#422 does this slightly correct; I have added the missing ones that weren't included in his PR

Gaming-setup & Aur helpers were skipped due to #382 and #380 which include refactoring for both of these functionality

ONLY after I made my 3 PRs did he decide to implement MY fixes.. before: 61cddeb after: 100fc58

My commits are VERIFIED, meaning everything that I do contains MY work. Take a look at these 2 commits and decide for your self. The first commit contained INCOMPLETE functionality and only after making my 3 PRs that fixed those issues did he decide to grab the changes in my commits and then implement them in his.

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• My changes generate no errors/warnings/merge conflicts.

[jeevithakannan2]

Are you serious ?? You could have asked me to make these changes in my PR itself !!!

Please close the new 2 competing PRs I am implementing these changes in the my PR itself

[nnyyxxxx]

Are you serious ?? You could have asked me to make these changes in my PR itself !!!

Please close the new 2 competing PRs I am implementing these changes in the my PR itself

No thanks.

[nnyyxxxx]

@jeevithakannan2 and do not steal my ideas, I correctly implemented where you failed, and as such maybe you should close your pr??

[jeevithakannan2]

Then what about the PR #443 . If what you're doing is not stealing then how come mine is stealing?

[jeevithakannan2]

And you have missed many places in this PR too

[nnyyxxxx]

And you have missed many places in this PR too

No? I implemented it correctly, also about #443 it was made because if he accepts my versions he can't merge yours or else it will conflict so thats why it was made. I can close that PR if you want the credit for that.

[nnyyxxxx]

You'll have to close your old pull request and make a new one though.

[jeevithakannan2]

Bruh you also didn't fully finish this PR !! Maybe you should close this one

[nnyyxxxx]

Bruh you also didn't fully finish this PR !! Maybe you should close this one

This PR is finished maybe you should tell me where its not

[nnyyxxxx]

gaming-setup was intentionally left out due to a rewrite in #380 if thats what you're referring to

[jeevithakannan2]

Bruh you also didn't fully finish this PR !! Maybe you should close this one

This PR is finished maybe you should tell me where its not !!

You could have done that to me told me where I have not finished it

[nnyyxxxx]

@jeevithakannan2 Not going to argue with you any longer; You're implementing the fix in areas where it does not need implemented. Such as Aurhelper, #382 . I have implemented the fix properly in these 3 PRs and yours is no longer needed, please close it.

[adamperkowski]

I think #440 #442 #443 approach this better. #422 is clearly copying the changes from them into his own implementation.