Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some Rust code structure and modified the workflow to fail if clippy returns warnings #569

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

adamperkowski
Copy link
Collaborator

Type of Change

  • Refactoring

Description

Changed the unnecessary then & unwrap_or to an if statement.
Modified the Rust workflow to fail if clippy returns warnings

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

@lj3954
Copy link
Contributor

lj3954 commented Sep 20, 2024

Making the title variable mutable and appending the " [Multi-Select]" str afterwards would probably be more readable.

@adamperkowski
Copy link
Collaborator Author

Making the title variable mutable and appending the " [Multi-Select]" str afterwards would probably be more readable.

Doing it like this may be less readable but it's better for the code. title doesn't need to be mutable.

@lj3954
Copy link
Contributor

lj3954 commented Sep 20, 2024

If you want to avoid mutability, you could perhaps try something like this instead: lj3954@8d7f2b7.

@adamperkowski
Copy link
Collaborator Author

If you want to avoid mutability, you could perhaps try something like this instead: lj3954@8d7f2b7.

Good idea. Thanks.

@ChrisTitusTech ChrisTitusTech merged commit f2332a7 into ChrisTitusTech:main Sep 21, 2024
1 check passed
@adamperkowski adamperkowski deleted the clippy branch September 21, 2024 14:56
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants