Move scripts around & refactor existing ones #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnyyxxxx
force-pushed
the
moveinstallingprintfsintoifstatements
branch
4 times, most recently
from
341f40f to
460db32
Compare
nnyyxxxx
force-pushed
the
moveinstallingprintfsintoifstatements
branch
from
460db32 to
7a840ff
Compare
|
ready to go |
5 tasks
|
gotta fix these conflicts before merge |
|
all good now |
adamperkowski
approved these changes
Sep 22, 2024
4 tasks
…fsintoifstatements
|
doing conflicts right now |
|
DONT MERGE YET |
|
draft it |
|
everything fixed and in place, ready for merge |
4 tasks
|
checkbashisms is failing for unknown reasons just ignore it |
nnyyxxxx
force-pushed
the
moveinstallingprintfsintoifstatements
branch
from
5b49620 to
e9b1217
Compare
4 tasks
ChrisTitusTech
approved these changes
Sep 22, 2024
|
going to fix these conflicts |
|
again lol |
…fsintoifstatements
|
@ChrisTitusTech all good now |
ChrisTitusTech
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #584 before this
Merge #596 before this as well
Merge #624 before this as well
Type of Change
Description
Moves scripts to better locations, and refactors some printf's into the if statements to prevent it from printing if the program(s) are already installed
Stop putting NEW LINES where the interactive printed message is, it just takes the user down a line, instead just use "%b" for those types of prints
Testing
tested
Checklist