Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9327: Unified number of search results for the filter searches #900

Merged
merged 9 commits into from
Feb 12, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 1, 2024

UHF-9327

What was done

  • Changed some of the React filter searches to list 15 items per page:
    • District and project search
    • Health station search
    • Maternity and child health clinic search
    • School search
  • Fixed issue with info_url being sometimes null on the event search and causing the event list not to load at all.
  • Refactored the hdbt-search__submit-button class away and replace it with hdbt-search--react__submit-button class.

How to install

  • To test all the searches listed above you need to test KYMP, SOTE and KASKO instances.
  • Make sure your instance is up and running on latest dev branch. With KASKO and KYMP you also need to take the feature branch that is linked on the Other PRs.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9327
  • Run make drush-cr drush-updb drush-cr

How to test

  • Go to each search listed above and check that they list 15 items per page.
  • Make sure the event search works correctly now. The paragraph didn't return any results with the example API-url but after the fix it works now. You can test this for example on SOTE https://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/lasten-ja-perheiden-palvelut/aitiys-ja-lastenneuvolat/1-6-vuotiaille-perheineen The event calendar doesn't print out any events on production and gives an error to console, but on your local it should work normally.
  • For the school search and event search check also that the search button is no longer a small button but instead around 280px wide in most cases. This means that now the buttons on all searches should be approximately the same size.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Other PRs

Copy link

github-actions bot commented Feb 9, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/900/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants