Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Visual regression error text #901

Merged
merged 2 commits into from
Feb 2, 2024
Merged

UHF-X Visual regression error text #901

merged 2 commits into from
Feb 2, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 2, 2024 •
edited by Arkkimaagi
Loading

What was done

  • Changed the text for the visual regression error text.

How to test

  • Check that the visual regression text has changed.
  • Check that code follows our standards

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/901/html_report/

@khalima khalima marked this pull request as ready for review February 2, 2024 10:19
Arkkimaagi
Arkkimaagi approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@khalima khalima merged commit 7ac6b48 into main Feb 2, 2024
2 checks passed
@khalima khalima deleted the UHF-X_change_visual_regression_error_text branch February 2, 2024 10:42
This was referenced Feb 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkkimaagi Arkkimaagi Arkkimaagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @Arkkimaagi