Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X Visual regression error text #901

Merged
merged 2 commits into from
Feb 2, 2024
Merged

UHF-X Visual regression error text #901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaab435
Changed the text for the visual regression error text.
khalima Feb 2, 2024
789b712
Changed the warning messaged slightly.
khalima Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/visual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
if: github.ref != 'refs/heads/main'
run: |
if ! npm run full-test; then
echo "result=❌ Tests failed!" >> $GITHUB_OUTPUT
echo "result=:warning: Visual regression found! Please check if this change is wanted or accidental. " >> $GITHUB_OUTPUT
else
echo "result=✅ Tests passed!" >> $GITHUB_OUTPUT
fi
Expand Down Expand Up @@ -153,4 +153,3 @@ jobs:
name: container-log
path: /tmp/container.log
retention-days: 1

Loading