Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10772: Add events list to Helsinki near you #792

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Dec 10, 2024

UHF-10772

Continues work on the Helsinki near you -feature.

What was done

  • Add template that embeds linkedevents app
  • Add new variables to drupalSettings
  • Add translations

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10772
    • make fresh
  • Get the HDBT feature branch: composer require drupal/hdbt:dev-UHF-10772
  • Run make drush-cr
  • Update translations: make drush-locale-update

How to test

Bonus points:

  • Test that the events paragraph still works as intended on a landing page

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

HDBT

* Add template that embeds linkedevents app
* Add new variables to drupalSettings
* Add translations
@jeremysteerio jeremysteerio marked this pull request as ready for review December 10, 2024 08:27
* No longer use bordered cards setting
* Add class to component
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go 🦖

@jeremysteerio jeremysteerio merged commit 21f1fbd into dev Dec 12, 2024
3 checks passed
@jeremysteerio jeremysteerio deleted the UHF-10772 branch December 12, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants