Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-11032: Changed exclusion logic for table of contents #865

Merged
merged 1 commit into from
Dec 11, 2024
Merged

UHF-11032: Changed exclusion logic for table of contents #865

merged 1 commit into from
Dec 11, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Dec 10, 2024 •
edited by teroelonen
Loading

UHF-11032

What was done

  • Added a generic class which excludes things from table of contents, prevents accidental class removals in the future affecting what is removed from table of contents.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11032
  • Run make drush-updb drush-cr

How to test

  • See instructions in hdbt pr

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@annadruid annadruid mentioned this pull request Dec 10, 2024
Merged
8 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

teroelonen
teroelonen approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice work! 🦖

@annadruid annadruid merged commit 79ab4ac into main Dec 11, 2024
5 checks passed
@annadruid annadruid deleted the UHF-11032 branch December 11, 2024 07:54
This was referenced Dec 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annadruid @teroelonen