Disable review environment

[voneiden]

The review environment has been broken for quite a while.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d75eb2f) 91.25% compared to head (9850f81) 91.25%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #465   +/-   ##
========================================
  Coverage    91.25%   91.25%           
========================================
  Files           55       55           
  Lines         2800     2800           
  Branches       329      329           
========================================
  Hits          2555     2555           
  Misses         189      189           
  Partials        56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[akikoskinen]

How about just removing the whole workflow?

[voneiden]

Mm not yet. I don't want to hide any evidence 2 days before the full maintenance responsibility shifts to ratkis. There's also the staging environment and gitlab references that need to be checked by Joku ™️ . If they're on longer in use and have been replaced by platta equivalents, then maybe there's further cleaning up to do in the Kubernetes.

I suppose you've not used these review and stage environments that kolga spins up at any point, or?

[akikoskinen]

Mm not yet. I don't want to hide any evidence 2 days before the full maintenance responsibility shifts to ratkis. There's also the staging environment and gitlab references that need to be checked by Joku ™️ . If they're on longer in use and have been replaced by platta equivalents, then maybe there's further cleaning up to do in the Kubernetes.

I suppose you've not used these review and stage environments that kolga spins up at any point, or?

These haven't been used for years, AFAIK. These (try to) deploy to some KuVa infrastructure somewhere. I'm surprised that any of them (the staging workflow at least) have succeeded during the last couple of years.

If this is the GitLab pipeline, it seems that it's not used either anymore.

There are no direct replacements. There hasn't been a need for review environments. develop branch does get automatically deployed to Platta DEV environment, but that's taken care of in Azure, not in this repository.

[charn]

LGTM! 👍